Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign label based on status (added, modified, removed) #79

Closed

Conversation

ericcornelissen
Copy link
Contributor

Closes #47, this refactors the existing logic to work with a File instead of just a filename (which for now just includes the filename and file status - "added","modified", or "removed"). It then uses this file status in the isMatch() function to check if the status is valid for the label.

I'm not 100% sure how this should be combined with all and any. Right now the status should hold for all, any, or both if it is specified at all.

@ericcornelissen

This comment has been minimized.

@pje pje closed this Jun 4, 2021
@pje pje deleted the branch actions:main June 4, 2021 18:48
@pje pje reopened this Jun 4, 2021
@pje pje changed the base branch from master to main June 4, 2021 19:13
@pje pje requested a review from a team as a code owner June 4, 2021 19:13
@ericcornelissen ericcornelissen closed this by deleting the head repository Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different label based on new/changed/removed
2 participants