Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing issue related to setting hostPort and containerPort when format is port/proto #38

Merged
merged 4 commits into from
Nov 15, 2022
Merged

fixing issue related to setting hostPort and containerPort when format is port/proto #38

merged 4 commits into from
Nov 15, 2022

Conversation

nikola-jokic
Copy link
Contributor

@nikola-jokic nikola-jokic requested review from a team as code owners November 9, 2022 13:00
thboop
thboop approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nikola-jokic nikola-jokic merged commit d988d96 into main Nov 15, 2022
@nikola-jokic nikola-jokic deleted the nikola-jokic/service-port-parsing branch November 15, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikola-jokic @thboop