-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot resolve localhost to an IPv6 address on ubuntu-latest (all Python versions affected) #929
Comments
I've investigated this further and it seems like IPv6 support is simply gone: https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700886122#step:5:21 It seems to be working for IPv4, but not for IPv6 anymore. |
Probably, similar to #668 |
I don't think so. As I wrote above, the problem started as of today (yesterday). It all worked fine before and now my builds started failing due to this. |
Give me a few minutes, will add pipelines for these to try it out |
Seems to be the same issue on Ubuntu 16: No IPv6 support available anymore
|
Could you please test with step?
|
@al-cheb is there something where I can tell it for a step to only do this on Linux? |
|
Looks good so far. I can resolve it to IPv6 again. Will however also wait for the whole pipeline and report back here |
@al-cheb we've started running into a very similar issue, specifically with Percy.io's image downloading functionality:
We use I tried including your suggested change to |
Hello, @agrobbin
|
@al-cheb that line did the trick! |
@al-cheb is this something that will be resolved in a future virtual environment release, or should we anticipate having to include this in our Actions YAML file going forward? |
Sounds good, @al-cheb thanks again for all of your help! In the meantime, I'll keep an eye on these issues. |
@al-cheb I just confirmed that removing our patch for this issue no longer causes resolution issues. Looks like things are fixed! Thanks so much for your help. |
I still have this problem after deleting this patch, is there any cache here? |
@yidongnan, Hello |
@al-cheb Using this patch will work, I read the comment saying that the patch removal is work. I thought the problem was fixed, but when I removed the patch, it found that it did not work. This is my modification |
I think we have got several issues one with resolving IPv4 localhost(revert PR fixed the issue) and the second one with IPv6. |
Hello, @yidongnan I have created a simple test:
Output:
Update
We are not planning to change/update default name resolution due to unexpected behaviors for other customers. Workaround:
|
@al-cheb Thanks for your reply, I see that ubuntu 18.04 and 14.04 have added ::1 localhost by default, so I think it’s more appropriate to be consistent with the ubuntu official. I think that only by being consistent will no unexpected behavior happen. |
Hello, @yidongnan |
@al-cheb Looks like things are fixed! Thanks so much for your help. |
Describe the bug
As of today I am getting the following error resolving
localhost
to an IP address on Ubuntu latest:The resolving process is done via Python:
It affects all Python versions: 2.6, 3.5, 3.6, 3.7, 3.8 pypy2 and pypy3
This has not happened a few days ago and it also does not happen on MacOS or Windows
Area for Triage:
https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700746839#step:5:2368
Question, Bug, or Feature?:
Bug
Virtual environments affected
Expected behavior
localhost
is resolved to::1
(IPv6)Actual behavior
The following error is thrown:
https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700886122#step:5:21
Reproducible via the following Python snippet on ubuntu-latest on all available Python versions.
https://github.com/cytopia/pwncat/pull/77/checks?check_run_id=700886122#step:5:21
The text was updated successfully, but these errors were encountered: