Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu, Windows] Docker Compose v1 will be removed from images on July, 29 #9692

Closed
6 of 12 tasks
mikhailkoliada opened this issue Apr 15, 2024 · 9 comments · Fixed by open-telemetry/opentelemetry-dotnet-contrib#1995

Comments

@mikhailkoliada
Copy link
Contributor

mikhailkoliada commented Apr 15, 2024

Breaking changes

Docker compose v1 will be removed from Ubuntu & Windows images.

Target date

The images rollout process will start on July, 29 and take 3-4 days.

The motivation for the changes

Docker compose v1 has been deprecated since July 2023 and customers are encouraged to migrate to v2, apart from that, as per our support policy it has been more that 6 months since the deprecation announcement so we would like to finally remove it. More information can also be found on the GitHub blog.

Possible impact

If your pipelines or workflows still depend on docker compose v1 they might be broken.

Platforms affected

  • Azure DevOps
  • GitHub Actions

Runner images affected

  • Ubuntu 20.04
  • Ubuntu 22.04
  • macOS 11
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • Windows Server 2019
  • Windows Server 2022

Mitigation ways

The last release of the v1 branch is still available on GitHub and can be downloaded and installed manually in runtime for both Ubuntu and Windows.

@daveisfera
Copy link

I understand removing it from new images (like the Ubuntu 24.04 one that was just released), but why remove it from existing images?
That means that if I make a branch from an old tag to release a bug fix that I have to also worry about patching this as well?

@actions actions deleted a comment from cPereira13 May 16, 2024
@Alexey-Ayupov Alexey-Ayupov changed the title [Ubuntu, Windows] Docker Compose v1 will be removed from images on July, 9 [Ubuntu, Windows] Docker Compose v1 will be removed from images on July, 29 Jun 27, 2024
@Alexey-Ayupov
Copy link
Collaborator

The removal of Docker Compose v1 is postponed till 29 of July.

@ShaharM7
Copy link

ShaharM7 commented Jun 27, 2024

@Alexey-Ayupov
My workaround for that on **Azure DevOps Pipelines ** is to pass the path of the docker-compose plugin (of course before it needs to install it on the Agents - in my case, it is Redhat 8 machines):

And the variable: $(docker_compose_exe_path) is - an example:

  - job: start_application_and_testing_for
    displayName: "Run E2E Tests For - "
    variables:
      - name: docker_compose_exe_path
        value: '/usr/libexec/docker/cli-plugins/docker-compose'`

    - task: DockerCompose@0
      displayName: 'Build Service Images'
      inputs:
        action: Build services
        dockerComposeFile: $(docker_compose_file_path)
        dockerComposePath: $(docker_compose_exe_path)
        detached: true
        dockerComposeFileArgs: |
          NPM_TOKEN=$(NPM_TOKEN)
          CI_BUILD_ID=$(Build.BuildId)
          AGENT_NAME=$(Agent.Name)

@sandywangkpmg
Copy link

sandywangkpmg commented Jul 5, 2024

@Alexey-Ayupov could you confirm if v2 executable will still be available at this path after the removal of v1? /usr/libexec/docker/cli-plugins/docker-compose

Found out the answer after looking into the source code.

install "$binary_path" "/usr/libexec/docker/cli-plugins/docker-$plugin"

@actions actions deleted a comment from hilop27 Jul 29, 2024
@actions actions deleted a comment from MMONSTER124 Jul 29, 2024
alexanderkiel added a commit to samply/blaze that referenced this issue Aug 1, 2024
GitHub Actions removed docker-compose:
actions/runner-images#9692

Also did some CQL and Dev Docs.
Bastian-Krause added a commit to Bastian-Krause/labgrid that referenced this issue Aug 1, 2024
Docker compose v1 has been deprecated since July 2023 [1]. Now the
GitHub actions Ubuntu runner images removed it, too [2]. So move to v2.

labgrid is obviously not affected by any changes between v1 and v2 other
than the compose call docker-compose -> docker compose.

[1] https://docs.docker.com/compose/migrate/
[2] actions/runner-images#9692

Signed-off-by: Bastian Krause <bst@pengutronix.de>
PascalRepond added a commit to rero/sonar that referenced this issue Aug 8, 2024
* Linked to deprecation of Docker Compose v1 in
Github Actions: actions/runner-images#9692
* Updates dependencies and fixes safety tests.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PatrickFuhrmann-HTWBerlin added a commit to PatrickFuhrmann-HTWBerlin/oai-provider-service that referenced this issue Aug 11, 2024
@ijunaidm ijunaidm self-assigned this Aug 13, 2024
tensor5 added a commit to teamdigitale/padigitale2026.gov.it-site that referenced this issue Aug 13, 2024
@ijunaidm
Copy link
Contributor

Thank you , Closing this issue as the Docker compose V1 got removed from both Windows and Ubuntu/MacOS images.

@ijunaidm ijunaidm unpinned this issue Aug 16, 2024
nafg added a commit to nafg/slick-migration-api that referenced this issue Aug 16, 2024
oittaa added a commit to oittaa/acme.sh that referenced this issue Aug 18, 2024
dtrifiro added a commit to dtrifiro/caikit-tgis-serving that referenced this issue Aug 20, 2024
v2 uses `docker compose` instead of `docker-compose`.

Ubuntu gha runners now ship with v2 only, see
actions/runner-images#9692
dtrifiro added a commit to dtrifiro/caikit-tgis-serving that referenced this issue Aug 20, 2024
v2 uses `docker compose` instead of `docker-compose`.

Ubuntu gha runners now ship with v2 only, see
actions/runner-images#9692
dtrifiro added a commit to dtrifiro/caikit-tgis-serving that referenced this issue Aug 20, 2024
v2 uses `docker compose` instead of `docker-compose`.

Ubuntu gha runners now ship with v2 only, see
actions/runner-images#9692
dtrifiro added a commit to opendatahub-io/caikit-tgis-serving that referenced this issue Aug 20, 2024
v2 uses `docker compose` instead of `docker-compose`.

Ubuntu gha runners now ship with v2 only, see
actions/runner-images#9692
dtrifiro added a commit to dtrifiro/caikit-tgis-serving that referenced this issue Aug 20, 2024
v2 uses `docker compose` instead of `docker-compose`.

Ubuntu gha runners now ship with v2 only, see
actions/runner-images#9692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

11 participants