Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ubuntu] Remove zip versions from Azuremodules #9774

Merged

Conversation

sssharif
Copy link
Contributor

@sssharif sssharif commented May 1, 2024

Removed zip versions redundant code from PowerShellAZ module script and removed the properties from toolsets.json.

Related issue: 6026

Check list

  • Related issue / work item is attached
  • Tests are written (if applicable)
  • Documentation is updated (if applicable)
  • Changes are tested and related VM images are successfully generated

@sssharif sssharif requested a review from maxim-lobanov May 2, 2024 19:42
@maxim-lobanov
Copy link
Contributor

/azp run ubuntu2004, ubuntu2204, ubuntu2404

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@sssharif sssharif force-pushed the ubuntu-fix-azureModules-zip-versions branch from c37505f to cafe600 Compare May 7, 2024 15:42
@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004,ubuntu2204,ubuntu2404

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004, ubuntu2204, ubuntu2404

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mikhailkoliada
Copy link
Contributor

/azp run ubuntu2004, ubuntu2204, ubuntu2404

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mikhailkoliada mikhailkoliada merged commit dca8e74 into actions:main May 13, 2024
7 checks passed
abhijit-hota added a commit to WarpBuilds/runner-images that referenced this pull request May 20, 2024
* [Ubuntu] Revert Podman, buildah and skopeo for Ubuntu-24.04 (actions#9825)

* [macOS] Add Xcode 15.4 Release Candidate (actions#9822)

* Updating readme file for macos-13 version 20240506.1 (actions#9800)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Ubuntu] Remove zip versions from Azuremodules (actions#9774)

* [Windows] Add .NET SDK 8.0 to Windows-2019 (actions#9838)

* Updating readme file for ubuntu24 version 20240510.1.1 (actions#9828)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* [Ubuntu] Add 24.04 to templates (actions#9847)

* [Windows] Update VS2022 code signature (actions#9850)

* README: mark ubuntu24 as beta (actions#9849)

* README: use the same tag for deprecated as for beta (actions#9852)

* [macOS] Add Xcode 15.4 Release (actions#9842)

* Updating readme file for macos-14 version 20240514.3 (actions#9857)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-13 version 20240514.3 (actions#9860)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu20 version 20240514.2.1 (actions#9855)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for win19 version 20240514.1.1 (actions#9856)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu22 version 20240514.2.1 (actions#9854)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for macos-13-arm64 version 20240514.3 (actions#9859)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Ubuntu] Patch azure-cli installer for Ubuntu 24.04 (actions#9863)

* Updating readme file for macos-12 version 20240514.3 (actions#9861)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* Updating readme file for win22 version 20240514.3.1 (actions#9853)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Ubuntu] Pin Helm 3.14.4 due to unusual release of 3.15.0 (actions#9867)

* Updating readme file for macos-14-arm64 version 20240514.3 (actions#9858)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* VisualStudioHelpers.ps1 stop enabling 8.3 filename creation (actions#9862)

The bug that prompted enabling 8.3 filename creation was fixed 5 years ago, see dotnet/android#3407:
> Fix included in Xamarin.Android 10.1.0.30.
>
> Fix included on Windows in Visual Studio 2019 version 16.4.

We're on VS 2019 16.11: https://github.com/actions/runner-images/blob/98150396188d19c21a7d7c596cf4a4d7609bb12a/images/windows/Windows2019-Readme.md?plain=1#L233

8.3 filename creation is known to hurt file creation performance, especially when there are a large number of similarly named files in the same folder:
* https://learn.microsoft.com/en-us/archive/blogs/josebda/windows-server-2012-file-server-tip-disable-8-3-naming-and-strip-those-short-names-too
* https://www.linkedin.com/pulse/dont-forget-disable-short-filenames-83-servers-folders-wes-brown
* https://deep.data.blog/2013/06/19/debugging-story-slowness-due-to-ntfs-short-file-8-3-name-generation/

I created a new VM with the base Azure Marketplace Windows 2019 image and confirmed that 8.3 name generation is disabled by default for both the OS and temp disk:
```
fsutil 8dot3name query C:
The volume state is: 1 (8dot3 name creation is disabled).
The registry state is: 2 (Per volume setting - the default).

Based on the above settings, 8dot3 name creation is disabled on C:

fsutil 8dot3name query D:
The volume state is: 1 (8dot3 name creation is disabled).
The registry state is: 2 (Per volume setting - the default).

Based on the above settings, 8dot3 name creation is disabled on D:
```

This might help a bit with actions/cache#752, although I haven't tested it, and AFAICT it's unlikely make an order of magnitude difference.

* Add ubuntu 24.04 to custom image scripts generator (actions#9868)

* Updating readme file for ubuntu20 version 20240516.1.1 (actions#9869)

Co-authored-by: Image generation service account <no-reply@microsoft.com>

* Updating readme file for ubuntu22 version 20240516.1.1 (actions#9870)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* Updating readme file for ubuntu24 version 20240516.4.1 (actions#9871)

Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>

* [Ubuntu] Add .NET SDKs 6 and 7 on Ubuntu 24.04 (actions#9878)

* [macos] Fix URLs in configure-preimagedata.sh (actions#9880)

* Fix macos-12 rollout badge (actions#9881)

* [macOS] Pin Swiftlint on macOS-12 due to Xcode 15.3 requirements (actions#9886)

* [Windows] Update signature for Azure CosmosDb Emulator (actions#9875)

* [Windows] Update signature for Azure CosmosDb Emulator

* Replace with SHA256

---------

Co-authored-by: Erik Bershel <110455084+erik-bershel@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Image generation service account <no-reply@microsoft.com>
Co-authored-by: Actions service account <no-reply@github.com>
Co-authored-by: sssharif <sssharif@github.com>
Co-authored-by: Mikhail Koliada <88318005+mikhailkoliada@users.noreply.github.com>
Co-authored-by: Congyi Wu <congyiwu@github.com>
Co-authored-by: Shamil Mubarakshin <127750046+shamil-mubarakshin@users.noreply.github.com>
guicaulada pushed a commit to grafana/runner-images that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants