Fix telemetry publish from JobServerQueue. (#2919)

src/Runner.Worker/JobRunner.cs

@@ -402,7 +402,12 @@ private async Task<TaskResult> CompleteJobAsync(IJobServer jobServer, IExecution
 
             try
             {
-                await ShutdownQueue(throwOnFailure: true);
+                var jobQueueTelemetry = await ShutdownQueue(throwOnFailure: true);
+                // include any job telemetry from the background upload process.
+                if (jobQueueTelemetry.Count > 0)
+                {
+                    jobContext.Global.JobTelemetry.AddRange(jobQueueTelemetry);
+                }
             }
             catch (Exception ex)
             {
@@ -412,13 +417,6 @@ private async Task<TaskResult> CompleteJobAsync(IJobServer jobServer, IExecution
                 result = TaskResultUtil.MergeTaskResults(result, TaskResult.Failed);
             }
 
-            // include any job telemetry from the background upload process.
-            if (_jobServerQueue != null &&
-                _jobServerQueue.JobTelemetries.Count > 0)
-            {
-                jobContext.Global.JobTelemetry.AddRange(_jobServerQueue.JobTelemetries);
-            }
-
             // Clean TEMP after finish process jobserverqueue, since there might be a pending fileupload still use the TEMP dir.
             _tempDirectoryManager?.CleanupTempDirectory();
 
@@ -511,14 +509,15 @@ private void LoadFromTelemetryFile(List<JobTelemetry> jobTelemetry)
             }
         }
 
-        private async Task ShutdownQueue(bool throwOnFailure)
+        private async Task<IList<JobTelemetry>> ShutdownQueue(bool throwOnFailure)
         {
             if (_jobServerQueue != null)
             {
                 try
                 {
                     Trace.Info("Shutting down the job server queue.");
                     await _jobServerQueue.ShutdownAsync();
+                    return _jobServerQueue.JobTelemetries;
                 }
                 catch (Exception ex) when (!throwOnFailure)
                 {
@@ -530,6 +529,8 @@ private async Task ShutdownQueue(bool throwOnFailure)
                     _jobServerQueue = null; // Prevent multiple attempts.
                 }
             }
+
+            return Array.Empty<JobTelemetry>();
         }
     }
 }