Implement env context, hashfiles, expression for input's default and post-if for wrapper action
#120
Conversation
TingluoHuang
force-pushed
the
users/tihuang/envcontext
branch
2 times, most recently
from
36e1236
to
b1009c0
Compare
TingluoHuang
changed the title
TingluoHuang
changed the title
|
Clarifying that this isn't prototyping. This is implementing and it's time critical for GA. This needs land with production level quality code. |
|
Is this ready for review? If so, we might not be able to depend on eric and find another reviewer. Eric is out. |
TingluoHuang
changed the title
post-if for wrapper action
TingluoHuang
force-pushed
the
users/tihuang/envcontext
branch
from
960c7fb
to
dfa8ff6
Compare
| @@ -83,6 +85,18 @@ | |||
| ], | |||
| "string": {} | |||
| }, | |||
| "input-default-context": { | |||
There was a problem hiding this comment.
May want to consider the name "string-default-context"
| envContext[name] = new StringContextData(value); | ||
| #else | ||
| var envContext = ExpressionValues["env"] as CaseSensitiveDictionaryContextData; | ||
| envContext[name] = new StringContextData(value); |
There was a problem hiding this comment.
super nit: can you pull out the envContext[name] line so we don't have to duplicate it.
| @@ -22,7 +22,7 @@ | |||
| "input": { | |||
| "mapping": { | |||
| "properties": { | |||
| "default": "string" | |||
| "default": "input-default-context" | |||
There was a problem hiding this comment.
shouldn't we support bool and numbers as well?
There was a problem hiding this comment.
with is string in the workflow schema, so the default should be string as well.
| public abstract ActionExecutionType ExecutionType { get; } | ||
|
|
||
| public abstract bool HasCleanup { get; } | ||
|
|
||
| public string CleanupCondition |
There was a problem hiding this comment.
Super nit:
I think you can do private string CleanupCondition{ get; set; } = $"{Constants.Expressions.Always}()";
TingluoHuang
force-pushed
the
users/tihuang/envcontext
branch
2 times, most recently
from
023b4ce
to
c7123c7
Compare
TingluoHuang
force-pushed
the
users/tihuang/envcontext
branch
from
c7123c7
to
d6508f1
Compare
Add runner group option
hashFiles()expression function:https://github.com/github/pe-actions-runtime/issues/85
envcontext for workflow variables:https://github.com/github/pe-actions-runtime/issues/86
allow expression for input's default value in
action.yml:https://github.com/github/pe-actions-runtime/issues/112
allow wrapper action definition
post-if:https://github.com/github/pe-actions-runtime/issues/113