Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace user-facing 'Agent' references with 'Runner' #125

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

juliobbv
Copy link
Contributor

@juliobbv juliobbv commented Oct 2, 2019

There were a few "user-facing" references to Agent, namely in both the run and config scripts, so I renamed them to Runner for consistency.

I also simplified the 'file unblocking' in config.cmd and run.cmd to remove the no-longer-needed Agent files while I'm here.

I decided to leave the code references (e.g. variable names) as Agent, as some of the server types include Agent in there. Replacing with runner would mean looking at code like this:

var taskRunnerSession = new TaskAgentSession(sessionName, runner, systemCapabilities);

...which I find more awkward than just leaving them as agent.

@juliobbv juliobbv mentioned this pull request Oct 2, 2019
11 tasks
@juliobbv juliobbv changed the title WIP: Replace 'Agent' references with 'Runner' Replace user-facing 'Agent' references with 'Runner' Oct 2, 2019
@juliobbv juliobbv merged commit 4ee02b5 into master Oct 2, 2019
@bryanmacfarlane
Copy link
Member

Thanks for taking the time to write a good description for this PR!

@juliobbv juliobbv deleted the users/juliobbv/replaceAgentWithRunner branch October 3, 2019 17:33
volker-raschek pushed a commit to dedalus-cis4u/github-runner-role that referenced this pull request Jul 25, 2022
…-checkout-3.x

Update actions/checkout action to v3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants