-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove additional fields on warning/error command issues #137
Conversation
foreach (var property in command.Properties) | ||
{ | ||
issue.Data[property.Key] = property.Value; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other properties in command
here that arent given by the user and would be lost?
Otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We write log line number but otherwise we don't want to pass anything else along.
See the addissue code below
runner/src/Runner.Worker/ExecutionContext.cs
Line 467 in 0dca481
issue.Data["logFileLineNumber"] = logLineNumber.ToString(); |
* Update to Version 2.160.0 (#144) * Revert "remove issue generation on warning/error commands (#137)" (#147) * Revert "remove issue generation on warning/error commands (#137)" This reverts commit 53da198. * Updated Release notes * Users/thboop/port directory changes (#152) * Clear action cache for local runner * update release notes for actions directory cache changes
* Update to Version 2.160.0 (actions#144) * Revert "remove issue generation on warning/error commands (actions#137)" (actions#147) * Revert "remove issue generation on warning/error commands (actions#137)" This reverts commit 53da198. * Updated Release notes * Users/thboop/port directory changes (actions#152) * Clear action cache for local runner * update release notes for actions directory cache changes
…mit-action-3.x Update pre-commit/action action to v3
Removes the ability for a user to pass through fields to the issue object. We still populate the
logFileLineNumber
field, but users should not be able to manually set other fields using these commands. Eventually they will be pushed towards using the add-annotation field for that behavior.https://github.com/github/pe-actions-runtime/issues/148