Bump runtime to dotnet 6 #1471
Bump runtime to dotnet 6 #1471
Conversation
TingluoHuang
force-pushed
the
users/tihuang/dotnet6
branch
from
0cc21a2 to
072f9c8
Compare
| <OutputType>Library</OutputType> | ||
| <RuntimeIdentifiers>win-x64;win-x86;linux-x64;linux-arm64;linux-arm;osx-x64</RuntimeIdentifiers> | ||
| <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch> | ||
| <NoWarn>NU1701;NU1603</NoWarn> | ||
| <Version>$(Version)</Version> | ||
| <TieredCompilationQuickJit>true</TieredCompilationQuickJit> |
There was a problem hiding this comment.
This is enabled by default since dotnet 5
| <OutputType>Exe</OutputType> | ||
| <RuntimeIdentifiers>win-x64;win-x86;linux-x64;linux-arm64;linux-arm;osx-x64</RuntimeIdentifiers> | ||
| <TargetLatestRuntimePatch>true</TargetLatestRuntimePatch> | ||
| <NoWarn>NU1701;NU1603</NoWarn> | ||
| <Version>$(Version)</Version> | ||
| <TieredCompilationQuickJit>true</TieredCompilationQuickJit> | ||
| <PublishReadyToRun>true</PublishReadyToRun> | ||
| <PublishReadyToRunComposite>true</PublishReadyToRunComposite> |
There was a problem hiding this comment.
PublishReadyToRunComposite is a replacing for PublishReadyToRun for self-contained app.
| @@ -1154,12 +1154,14 @@ private void SetServicePointOptions() | |||
| { | |||
| if (BaseAddress != null) | |||
| { | |||
| #pragma warning disable SYSLIB0014 | |||
There was a problem hiding this comment.
ServicePointManager is deprecated, but I didn't find an equivalent in dotnet 6, so I disable the warning and keep using the old API.
| @@ -138,7 +138,7 @@ public static class VssHttpUriUtility | |||
|
|
|||
| if (routeReplacementOptions.HasFlag(RouteReplacementOptions.EscapeUri)) | |||
| { | |||
| sbResult = new StringBuilder(Uri.EscapeUriString(sbResult.ToString())); | |||
There was a problem hiding this comment.
EscapeUriString is deprecated...
| @@ -15,7 +15,7 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.0.0" /> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.0.0" /> | |||
There was a problem hiding this comment.
v15 had some bug that will cause all tests to hang in dotnet 6
| @@ -1,4 +1,5 @@ | |||
| #if OS_WINDOWS | |||
There was a problem hiding this comment.
dotnet 6 introduced api platform check at compile time.
We already did our platform check using #if OS_WINDOWS, so we can just disable the working everywhere we have #if OS_WINDOWS
| @@ -1,4 +1,5 @@ | |||
| #if OS_WINDOWS | |||
| #pragma warning disable CA1416 | |||
There was a problem hiding this comment.
Not sure why this pragma is needed. I didn't experience any problems on my branch with these warnings
There was a problem hiding this comment.
Taking it back. This is within If Windows block and I didn't test building on Windows
| @@ -1,4 +1,5 @@ | |||
| #if OS_WINDOWS | |||
| #pragma warning disable CA1416 | |||
There was a problem hiding this comment.
Taking it back. This is within If Windows block and I didn't test building on Windows
TingluoHuang
force-pushed
the
users/tihuang/dotnet6
branch
from
5bb5002 to
c96a53e
Compare
|
is this blocked? sorry for annoying, but I'm waiting for that as I want to migrate from Jenkins to GHA, and can't move because of the absence of arm support =( |
|
And then there will be another regression and it will be reverted to netcore, has been |
This reverts commit 801a02e.
* bump runtime to dotnet 6
Dotnet 6 has been released and the runner is on dotnet 3.1 which is a 2 years old runtime.
In order to unblock macOS M1 support, I am trying to bump the dotnet runtime in the runner first.
https://github.com/github/c2c-actions-runtime/issues/1523