Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency check for dotnet 6. #1551

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Update dependency check for dotnet 6. #1551

merged 1 commit into from
Dec 15, 2021

Conversation

TingluoHuang
Copy link
Member

Dotnet renames its native lib from System.*.so to libSystem.*.so since dotnet 5, we need to change our script to check the right files, otherwise, you will get annoying output like

ldd: ./bin/System.Security.Cryptography.Native.OpenSsl.so: No such file or directory
ldd: ./bin/System.IO.Compression.Native.so: No such file or directory

@TingluoHuang TingluoHuang requested a review from a team as a code owner December 10, 2021 21:45
thboop
thboop approved these changes Dec 15, 2021
View reviewed changes
Copy link
Collaborator

@thboop thboop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TingluoHuang TingluoHuang merged commit 3ec20e9 into main Dec 15, 2021
@TingluoHuang TingluoHuang deleted the users/tihuang/dotnet6cleanup branch December 15, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thboop thboop thboop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingluoHuang @thboop