Support downloading/publishing artifacts from Pipelines endpoint #188
Conversation
juliobbv
requested review from
ericsciple,
IAmHughes,
yacaovsnc and
thboop
and removed request for
IAmHughes
|
Should we take this chance to change artifact action to typescript? |
|
Good question @TingluoHuang. We'll still need the changes from the PR for the v1 plugin version (for back-compat), as the Build2 endpoints of publish/download artifacts are scheduled to be removed some time soon. cc @yacaovsnc |
I wouldn't do this as then the user would have the choice of not upgrading to latest version of the action. In our case, we want to force upgrade user to use the runner so they use latest APIs. |
|
Hey @thboop, @yacaovsnc, @ericsciple: now that the server-side Actions changes are now merged, can I get a final review of this PR when you have a chance? |
juliobbv
force-pushed
the
users/juliobbv/addActionsPipelinesWebApi
branch
from
b8eaeef
to
a8434d6
Compare
|
I'm attaching the run logs that use v1 (Build2), and v2 (Pipelines) endpoints. They report the same things, so from the user's point of view, the change is transparent: |
juliobbv
force-pushed
the
users/juliobbv/addActionsPipelinesWebApi
branch
from
a8434d6
to
841e069
Compare
|
FYI -- github/pe-actions-runtime#229 tracks the effort to convert these Artifact actions to TypeScript |
…ions#188) * Support downloading/publishing artifacts from Pipelines endpoint * Remove `Path` from everywhere * Remove unused JobId argument * PR feedback * More PR feedback
This PR adds a minimal C#
PipelinesHttpClientthat only contains methods that the runner can use for managing artifacts. Then, this PR implements a mechanism to download/publish artifacts by using the Pipelines endpoint via the HTTP client.Tested scenarios:
Build2endpointPipelinesendpointBuild2to publish artifact,Pipelinesto download