-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support downloading/publishing artifacts from Pipelines endpoint #188
Conversation
Should we take this chance to change artifact action to typescript? |
Good question @TingluoHuang. We'll still need the changes from the PR for the v1 plugin version (for back-compat), as the Build2 endpoints of publish/download artifacts are scheduled to be removed some time soon. cc @yacaovsnc |
I wouldn't do this as then the user would have the choice of not upgrading to latest version of the action. In our case, we want to force upgrade user to use the runner so they use latest APIs. |
Hey @thboop, @yacaovsnc, @ericsciple: now that the server-side Actions changes are now merged, can I get a final review of this PR when you have a chance? |
b8eaeef
to
a8434d6
Compare
I'm attaching the run logs that use v1 (Build2), and v2 (Pipelines) endpoints. They report the same things, so from the user's point of view, the change is transparent: |
a8434d6
to
841e069
Compare
FYI -- github/pe-actions-runtime#229 tracks the effort to convert these Artifact actions to TypeScript |
…ions#188) * Support downloading/publishing artifacts from Pipelines endpoint * Remove `Path` from everywhere * Remove unused JobId argument * PR feedback * More PR feedback
This PR adds a minimal C#
PipelinesHttpClient
that only contains methods that the runner can use for managing artifacts. Then, this PR implements a mechanism to download/publish artifacts by using the Pipelines endpoint via the HTTP client.Tested scenarios:
Build2
endpointPipelines
endpointBuild2
to publish artifact,Pipelines
to download