Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit on deprication error #2299

Merged
merged 9 commits into from
Mar 7, 2023

Conversation

nikola-jokic
Copy link
Contributor

Fixes #2246

@nikola-jokic nikola-jokic marked this pull request as ready for review February 28, 2023 14:08
@nikola-jokic nikola-jokic requested a review from a team as a code owner February 28, 2023 14:08
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhammerl fhammerl merged commit fd96246 into actions:main Mar 7, 2023
nikola-jokic added a commit to nikola-jokic/runner that referenced this pull request May 12, 2023
* terminate the runner on deprication message

* added TaskAgentVersion exception to catch deprication

* AccessDenied exception with inner exception InvalidTaskAgent

* Access denied exception in program and in message listener

* Fixed copy

* remove trace message from message listener
@nikola-jokic nikola-jokic deleted the nikola-jokic/deprication-error branch July 11, 2023 09:06
@@ -182,7 +182,7 @@ public void OnJobStatus(object sender, JobStatusEventArgs e)
try
{
_getMessagesTokenSource?.Cancel();
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

';.;;''

AdamOlech pushed a commit to antmicro/runner that referenced this pull request Aug 14, 2024
* terminate the runner on deprication message

* added TaskAgentVersion exception to catch deprication

* AccessDenied exception with inner exception InvalidTaskAgent

* Access denied exception in program and in message listener

* Fixed copy

* remove trace message from message listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit on "Runner is deprecated and cannot receive messages"
3 participants