-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add file size check prior to reading file #2321
Re-add file size check prior to reading file #2321
Conversation
@@ -182,6 +182,14 @@ public void ProcessCommand(IExecutionContext context, string filePath, Container | |||
return; | |||
} | |||
|
|||
if (fileSize > AttachmentSizeLimit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably also remove this block where it is added in the if/else block below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 674f15b!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!!
@bethanyj28 Please cherry-pick the fix back to the main branch. |
* Re-add file size check prior to reading file * Remove redundant file size check
@TingluoHuang PR open: #2330 Thanks! |
…2330) * Re-add file size check prior to reading file * Remove redundant file size check
The job hangs when uploading a large summary file since we had moved a file size check to another location. We suspect it has to do with
MaskSecrets
reading the file, but we will re-add the check to fix the issue for the time being.Prior to the change:
After the change: