Re-add file size check prior to reading file #2321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -182,6 +182,14 @@ public void ProcessCommand(IExecutionContext context, string filePath, Container | |||
| return; | |||
| } | |||
|
|
|||
| if (fileSize > AttachmentSizeLimit) | |||
There was a problem hiding this comment.
We should probably also remove this block where it is added in the if/else block below
There was a problem hiding this comment.
Removed in 674f15b!
|
@bethanyj28 Please cherry-pick the fix back to the main branch. |
bethanyj28
added a commit
to bethanyj28/runner
that referenced
this pull request
Dec 19, 2022
* Re-add file size check prior to reading file * Remove redundant file size check
|
@TingluoHuang PR open: #2330 Thanks! |
TingluoHuang
pushed a commit
that referenced
this pull request
Dec 19, 2022
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
…2330) * Re-add file size check prior to reading file * Remove redundant file size check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The job hangs when uploading a large summary file since we had moved a file size check to another location. We suspect it has to do with
MaskSecretsreading the file, but we will re-add the check to fix the issue for the time being.Prior to the change:
After the change:
