-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly guard upload #2439
Properly guard upload #2439
Conversation
actions#2437)" This reverts commit 8c096ba.
if (timelineRecordId == _jobTimelineRecordId && String.Equals(type, CoreAttachmentType.ResultsLog, StringComparison.Ordinal)) | ||
{ | ||
Trace.Verbose("Skipping job log {0} for record {1}", path, timelineRecordId); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, do we need to delete the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not going to delete here since I am going to remove this check now in my next PR. I already have the code mostly ready, just need to test and submit a PR.
The general ff case is handled by the first delete above.
* Revert "Revert "Uploading step logs to Results as well (actions#2422)" (actions#2437)" This reverts commit 8c096ba. * Properly guard the upload to results feature * Delete skipped file if deletesource is true
* Revert "Revert "Uploading step logs to Results as well (actions#2422)" (actions#2437)" This reverts commit 8c096ba. * Properly guard the upload to results feature * Delete skipped file if deletesource is true
Fix 2.302 upload log issue