Update runner to handle Dotcom/runner-admin based registration flow #2487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Delete | ||
| } | ||
|
|
||
| public class RunnerDotcomServer : RunnerService, IRunnerDotcomServer |
There was a problem hiding this comment.
nice! I like the refactor to it's own class
takost
changed the title
|
|
||
| public List<TaskAgent> ToTaskAgents() | ||
| { | ||
| List<TaskAgent> taskAgents = new List<TaskAgent>(); |
luketomlinson
previously approved these changes
Mar 16, 2023
8 tasks
nikola-jokic
pushed a commit
to nikola-jokic/runner
that referenced
this pull request
May 12, 2023
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/github/actions-runner-admin/issues/120
Add to runner settings property to identify if we register this runner via runner-admin and not Actions Service. Value of this property comes from dotcom side, where it is defined as feature flag. This value can't be provided via configuration argument. In future this will define behaviour of whole runner flow (assignment, deletion, etc.)
Add class to make call to dotcom. Add there functions to get runnergroups, list runners and add new runner. Right now we don't implement update of runner (replacement of runner if runner with provided name already exists during runner registration).