Enable linux/arm64 docker build and publish #2601
Conversation
|
I'm prototyping https://github.com/actions/actions-runner-controller by pointing it to my local colima instance on my Mac. I was surprised to see everything running through emulation and not native binaries. It looks like the underlying issue is that the runner is only amd64, so all binaries inside of it fall back to that too. |
|
I hope this gets merged soon. My team is currently building our own @nikola-jokic, @TingluoHuang, any thoughts on when/if this PR can be merged? |
|
Hey everyone, We are planning to address this issue, hopefully before the next release However, we will create a separate PR to address this issue since we also need to publish images with correct labels and have it be part of the release process |
…/enable-arm64-docker Signed-off-by: Dee Kryvenko <dm.kryvenko@gmail.com>
There was a problem hiding this comment.
LGTM! @TingluoHuang I tested it on my local repo and just moved these changes there. Everything works 😄 Do you mind also taking a look just in case. I'm confident this is all we need
* Enable linux/arm64 docker build and publish * Fix Dockerfile for multi-arch * Fix Dockerfile - missing args * Fix Dockerfile - Docker likes x86_64 * Remove unused `RUNNER_ARCH` --------- Signed-off-by: Dee Kryvenko <dm.kryvenko@gmail.com>
Details
|
Hey all - I am not sure if it was intentionally not enabled, but on the off chance it wasn't...