Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Using V2 Flow" log to Trace instead of WriteLine #2635

Merged
merged 1 commit into from
May 31, 2023
Merged

Move "Using V2 Flow" log to Trace instead of WriteLine #2635

merged 1 commit into from
May 31, 2023

Conversation

luketomlinson
Copy link
Contributor

There is no need to pollute the output of Runner Registration with this tracing. Move it to the logs.

@luketomlinson luketomlinson requested a review from a team as a code owner May 31, 2023 14:12
JoannaaKL
JoannaaKL approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@JoannaaKL JoannaaKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@luketomlinson luketomlinson merged commit e13627d into main May 31, 2023
@luketomlinson luketomlinson deleted the luketomlinson/v2-logging branch May 31, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rentziass rentziass rentziass approved these changes

@JoannaaKL JoannaaKL JoannaaKL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luketomlinson @rentziass @JoannaaKL