Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RunnerId/AgentId from int32 to uint64 #2661

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

TingluoHuang
Copy link
Member

@TingluoHuang TingluoHuang requested a review from a team as a code owner June 16, 2023 03:00
@fhammerl
Copy link
Contributor

There's a few int agentId's left in TaskAgentHttpClientBase, should we update them too?

@TingluoHuang
Copy link
Member Author

There's a few int agentId's left in TaskAgentHttpClientBase, should we update them too?

@fhammerl Less worry about for now since those are unused.

fhammerl
fhammerl previously approved these changes Jul 7, 2023
Copy link
Contributor

@fhammerl fhammerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang changed the title Change RunnerId/AgentId from int32 to int64 Change RunnerId/AgentId from int32 to uint64 Jul 19, 2023
@TingluoHuang TingluoHuang merged commit 8fa970a into main Aug 4, 2023
10 checks passed
@TingluoHuang TingluoHuang deleted the users/tihuang/longagentid branch August 4, 2023 20:22
ashb pushed a commit to ashb/runner that referenced this pull request Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants