change hashFiles() expression to use @actions/glob. #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
force-pushed
the
users/tihuang/findfiles
branch
2 times, most recently
from
e99e689
to
32bd511
Compare
ericsciple
reviewed
Jan 13, 2020
| } | ||
| } | ||
|
|
||
| public sealed class HashFiles : Function |
There was a problem hiding this comment.
have you considered allowing multiple patterns? That is, minParameters: 1, maxParameters: int.MaxValue
If multiple patterns, check if the first one is --follow-symbolic-links otherwise add it to the list of patterns.
There was a problem hiding this comment.
i am trying switch hashfiles to use actions/glob in this PR without any behavior changes and add multiple patterns later.
There was a problem hiding this comment.
support multiple actually make the code simple, i will do it.
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
ericsciple
approved these changes
Jan 13, 2020
ericsciple
reviewed
Jan 13, 2020
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es6", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ | |||
There was a problem hiding this comment.
i wonder if this should be ES2019. Or have you considered just regular javascript since now much code. Your call.
TingluoHuang
force-pushed
the
users/tihuang/findfiles
branch
from
30d4746
to
2972167
Compare
This was referenced Feb 5, 2020
AdamOlech
pushed a commit
to antmicro/runner
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234