Pass timeout in executioncontext instead of stepsrunner #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhammerl
commented
Jul 25, 2023
| @@ -421,8 +421,6 @@ private async Task RunStepAsync(IStep step) | |||
| { | |||
| Trace.Info($"Starting: {step.DisplayName}"); | |||
| step.ExecutionContext.Debug($"Starting: {step.DisplayName}"); | |||
| // composite steps inherit the timeout from the parent, set by https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepstimeout-minutes | |||
| step.ExecutionContext.SetTimeout(step.ExecutionContext.Parent.GetRemainingTimeout()); | |||
There was a problem hiding this comment.
In previous fix I treated step.ExecutionContext.Parent.ExecutionContext as the EC of workflow or composite step creating step, but it is actually the EC of the job because comp steps are created by Root
nikola-jokic
previously approved these changes
Jul 25, 2023
JoannaaKL
previously approved these changes
Jul 25, 2023
nikola-jokic
approved these changes
Jul 25, 2023
fhammerl
added a commit
that referenced
this pull request
Jul 25, 2023
* Pass timeout in executioncontext instead of stepsrunner * Fix linting
fhammerl
added a commit
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.