Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node16 to latest version #2736

Merged
merged 9 commits into from
Aug 9, 2023
Merged

Update node16 to latest version #2736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9864465
Update node16 to latest
takost Aug 3, 2023
de87812
add available version for win-arm64
takost Aug 7, 2023
922971c
fix externals hash
takost Aug 7, 2023
9f38adc
fix externals hashes
takost Aug 7, 2023
4257768
fix externals hash
takost Aug 7, 2023
1abca04
fix externals hash
takost Aug 7, 2023
4f74a53
fix externals hash
takost Aug 7, 2023
2c9ee73
fix externals hash
takost Aug 8, 2023
338fd85
fix spacing
takost Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/linux-arm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3807dcbf947e840c33535fb466b096d76bf09e5c0254af8fc8cbbb24c6388222
205b567a8c3a5117e5f405dc807b2f30d92634ce3c1a542736b2ad626411d3f5
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/linux-arm64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ee01eee80cd8a460a4b9780ee13fdd20f25c59e754b4ccd99df55fbba2a85634
3fb61ee5226e14d2ff8e4415d32da311f72243a8ba68ad280e85aef6f3950329
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/linux-x64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a9fb9c14e24e79aec97d4da197dd7bfc6364297d6fce573afb2df48cc9a931f8
88cdd58d606bff13857a09fd13f207f0e9360820d036fc8b53b34759abd9baa8
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/osx-arm64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a4e0e8fc62eba0967a39c7d693dcd0aeb8b2bed0765f9c38df80d42884f65341
4eb04e10e173b1f5d7cf8890878a3e178de162e5bf1a583067cf704b8162631a
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/osx-x64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
17ac17fbe785b3d6fa2868d8d17185ebfe0c90b4b0ddf6b67eac70e42bcd989b
c6267cf59873f58c9d6fa23e2fe72ea41ca578452c8ae60f6cdb599ae7674eb0
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/win-arm64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
89f24657a550f1e818b0e9975e5b80edcf4dd22b7d4bccbb9e48e37f45d30fb1
0064acac3fba3bd29851334c90f53adc13f88f2d23f5909f3bbec2b1c4ade9ef
2 changes: 1 addition & 1 deletion src/Misc/contentHash/externals/win-x64
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
24fd131b5dce33ef16038b771407bc0507da8682a72fb3b7780607235f76db0b
b671357b482eba5a3b166303f4943372e908ab8b243f122afc8ee08903a22ab0
8 changes: 5 additions & 3 deletions src/Misc/externals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@ PRECACHE=$2
NODE_URL=https://nodejs.org/dist
UNOFFICIAL_NODE_URL=https://unofficial-builds.nodejs.org/download/release
NODE12_VERSION="12.22.7"
NODE16_VERSION="16.16.0"
NODE16_VERSION="16.20.1"
# used only for win-arm64, remove node16 unofficial version when official version is available
NODE16_UNOFFICIAL_VERSION="16.20.0"

get_abs_path() {
# exploits the fact that pwd will print abs path when no args
Expand Down Expand Up @@ -149,8 +151,8 @@ fi
# Download the external tools only for Windows.
if [[ "$PACKAGERUNTIME" == "win-arm64" ]]; then
# todo: replace these with official release when available
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_VERSION}/$PACKAGERUNTIME/node.lib" node16/bin
acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_UNOFFICIAL_VERSION}/$PACKAGERUNTIME/node.exe" node16/bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for explicit naming

acquireExternalTool "$UNOFFICIAL_NODE_URL/v${NODE16_UNOFFICIAL_VERSION}/$PACKAGERUNTIME/node.lib" node16/bin
if [[ "$PRECACHE" != "" ]]; then
acquireExternalTool "https://github.com/microsoft/vswhere/releases/download/2.6.7/vswhere.exe" vswhere
fi
Expand Down