Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace x-github-request-id when download action tarball. #2755

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

TingluoHuang
Copy link
Member

@TingluoHuang TingluoHuang requested a review from a team as a code owner August 10, 2023 18:23
@@ -19,8 +19,6 @@ public interface IRunnerDotcomServer : IRunnerService

Task<DistributedTask.WebApi.Runner> AddRunnerAsync(int runnerGroupId, TaskAgent agent, string githubUrl, string githubToken, string publicKey);
Task<List<TaskAgentPool>> GetRunnerGroupsAsync(string githubUrl, string githubToken);

string GetGitHubRequestId(HttpResponseHeaders headers);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved into UrlUtil.cs so we can share this across multiple csproj.

Copy link
Contributor

@vanZeben vanZeben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TingluoHuang TingluoHuang merged commit 4f40f29 into main Aug 15, 2023
10 checks passed
@TingluoHuang TingluoHuang deleted the users/tihuang/tracerequestid branch August 15, 2023 23:00
ashb pushed a commit to ashb/runner that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants