Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change prompt message when removing a runner #303

Merged
merged 2 commits into from
Jan 26, 2020

Conversation

gimenete
Copy link
Contributor

Closes https://github.com/github/c2c-actions-experience/issues/2128

To be consistent with the API and the UI we've decided to use remove token instead of deletion token.

@gimenete gimenete marked this pull request as ready for review January 24, 2020 16:52
Copy link
Contributor

@mscoutermarsh mscoutermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@TingluoHuang TingluoHuang merged commit 2e0e8eb into master Jan 26, 2020
@TingluoHuang TingluoHuang deleted the change-runner-prompt-message branch January 26, 2020 23:40
AdamOlech pushed a commit to antmicro/runner that referenced this pull request Jan 28, 2021
* Change prompt message to be consistent with the UI/API

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants