Fix JobDispatcher crash during force cancellation. #3118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JobDispatcher will crash in this scenario:
AnonymousPipe
AnonymousPipe
failed since the worker exited, exception get thrown and crashed theJobDispatcher
The fix: add another
catch(Exception)
to make sure the failure on sending cancellation don't crash the JobDispatcher.https://github.com/github/c2c-actions-support/issues/3423