-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade node20: 20.8.1 → 20.13.1 #3284
Conversation
Building a new release of |
src/Misc/externals.sh
Outdated
NODE16_VERSION="16.20.2" | ||
NODE20_VERSION="20.8.1" | ||
NODE20_VERSION="20.13.1" | ||
# used only for win-arm64, remove node16 unofficial version when official version is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does win-arm64 not having node20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do! They've got a release for win-arm64
at 20.13.1: https://nodejs.org/dist/v20.13.1/
I think that comment was meant for node16, which doesn't seem to have an official win-arm64 release: https://nodejs.org/dist/v16.20.2/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move that comment to the end of the line so it's more obvious which variable it's referring to:
2503260
…riable it's talking about
This is ready to go! Anyone from @actions/actions-runtime should feel free to merge this for the next runner release, otherwise I'll plan to do so early next week. |
✅ Brings us up to date with the latest LTS release of Node
✅ Pulls in many important security upgrades
✅ Addresses the following issues: