Cleanup back-compat code for interpreting Run Service status codes #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingluoHuang
approved these changes
Sep 6, 2024
ericsciple
commented
Sep 6, 2024
| @@ -107,15 +107,6 @@ public async Task<AgentJobRequestMessage> GetJobMessageAsync( | |||
| } | |||
| } | |||
|
|
|||
| // Temporary back compat | |||
| switch (result.StatusCode) | |||
There was a problem hiding this comment.
Tested E2E to make sure everything is still working as expected. Specifically I tested the 422 UnprocessableEntity scenario above. Easy to repro that scenario via reusable workflow with a required secret, with the caller providing an expression that evaluates to empty/nil.
There was a problem hiding this comment.
name: CI
on:
workflow_dispatch:
jobs:
build:
uses: ./.github/workflows/reuse.yml
secrets:
foo: ${{ github.nosuch }}# .github/workflows/reuse.yml
on:
workflow_call:
secrets:
foo:
description: asdf
required: true
jobs:
build:
runs-on: self-hosted
steps:
- run: echo hi
env:
FOO_SECRET: ${{ secrets.foo }}
ericsciple
force-pushed
the
users/ericsciple/24-09-cleanup
branch
from
010753b
to
b3de9de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.