-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding wrapper action to support post job cleanup, checkout just work #91
Conversation
6bca89d
to
f4094e7
Compare
// Prepare self-signed CA cert config for fetch from server. | ||
if (useSelfSignedCACert) | ||
{ | ||
executionContext.Debug($"Use self-signed certificate '{runnerCert.CACertificateFile}' for git fetch."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why does fetch work differently here, just curious
} | ||
else | ||
{ | ||
throw new NotSupportedException(key); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: consider assert.fail
f4094e7
to
3486b82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the git commands are a little outside my area of expertise so you may want to consider getting someone else to review that or we can sit in a room and discuss it if you are worried about it.
3486b82
to
bf5b001
Compare
4b2e2f4
to
97ada5d
Compare
Handle exception in executeHookScript
Develop to Master
No description provided.