-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Action fails to install semver exact match or constraint prerelease go version #191
Comments
Signed-off-by: Marko Kungla <marko.kungla@gmail.com>
Hello @mkungla. Thank you for your report. Could you please try to use this snippet: - name: Setup Go
uses: actions/setup-go@v2
with:
go-version: 1.18.0-rc1
stable: false |
@dmitry-shibanov I clarified and edited my comment |
@dmitry-shibanov I think this is fixed, as |
The v3 docs say that semver ranges are supported, but I can't get any of these to work:
I'm trying to do something rather simple: support everything from 1.18rc1 and onward. Is this possible? |
OK, this seems to work:
:) |
@tliron I must have missed something then because using |
@mlcdf Use |
Oh, I missed that part, thank you very much! It works! |
The README file still shows v2. I will open an issue for that. |
this can be closed wehen merging #202 seems that in general this issue is resolved |
Hi @mkungla, I'm going to close this issue cause the docs were updated. Feel free to contact as if you have any questions, thank you! |
Description:
Documentation states that
semver
prerelease can be installed, but action fails with following error.Unable to find Go version '1.18.0-rc1' for platform linux and architecture x64.
As @dmitry-shibanov pointed out in hes comment #191 (comment) using
stable: false
works. However whenaction@v2
claims to be Semver compliant on parsing versions as clearly stated in README then it SHOULD NOT be expected to require additional configuration flag. Version parsing and handling SHOULD then expected fully be handled by Semver constraints.There are 2 options either to fix this:
stable
flag and follow fully Semver version comparisons constraint parsing principles.Working With Prerelease Versions
And in node semver package: Prerelease Tags
as conclusion e.g. config which currently fail, while they are expected to succeed
Action version:
actions/setup-go@v2
Platform:
Runner type:
Tools version:
1.18.0-rc1
Repro steps:
https://github.com/mkungla/github-cicd/runs/5246697691?check_suite_focus=true
Expected behavior:
1.18.0-rc1
to be installed as defined in matrixhttps://go.dev/dl/?mode=json&include=all has 1.18
Actual behavior:
workflow fails to install
go1.18rc1
The text was updated successfully, but these errors were encountered: