-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cache key do not include linux distro name and version #368
Comments
Hello @kolyshkin. Thank you for your report. We'll take a look on issue. |
This action uses the following cache key: Surely, mixing caches from different Ubuntu versions is not a good thing. The fix is to add a distro name and version (such as A workaround (in my specific case) would be to add something like PS found that this problem is not specific to this repo, and someone has already developed a workaround: https://github.com/marketplace/actions/github-actions-runner-os-system-information (note the "Example"). |
Filed actions/runner#2527 |
Can I inquire about the potential timeline for the fix? Also, I tried to help by making the fix easier (actions/runner#2527) but it didn't work. |
actions/setup-go#368 and opencontainers/runc#3820 (comment) discuss issues with the cache key for actions/setup-go@v4. Rather than reverting the upgrade to v4 (per discussion in containerd#8372), disable caching explicitly. Signed-off-by: Samuel Karp <samuelkarp@google.com>
d |
update all the github actions using node12 to version that use node16 - update actions/checkout@v2 -> v3 - update actions/cache@v2 -> v3 - update actions/setup-go@v2 -> v4 cache has been set to disabled for setup-go due to actions/setup-go#368 Signed-off-by: Akhil Mohan <makhil@vmware.com>
The issue is closed because of #383 has been merged |
Fixed in https://github.com/actions/setup-go/releases/tag/v4.1.0 which was released today. Thanks! |
Since actions/setup-go#368 is now fixed (in https://github.com/actions/setup-go/releases/tag/v4.1.0), there is no need to disable caching when using different distros. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since actions/setup-go#368 is now fixed (in https://github.com/actions/setup-go/releases/tag/v4.1.0), there is no need to disable caching when using different distros. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
actions/setup-go#368 and opencontainers/runc#3820 (comment) discuss issues with the cache key for actions/setup-go@v4. Rather than reverting the upgrade to v4 (per discussion in containerd#8372), disable caching explicitly. Signed-off-by: Samuel Karp <samuelkarp@google.com>
actions/setup-go#368 and opencontainers/runc#3820 (comment) discuss issues with the cache key for actions/setup-go@v4. Rather than reverting the upgrade to v4 (per discussion in containerd#8372), disable caching explicitly. Signed-off-by: Samuel Karp <samuelkarp@google.com>
Description:
setup-go@v4 added
/home/runner/.cache/go-build
caching, which does not take the OS version into account, as a result, cache saved from Ubuntu 22.04 can be used on Ubuntu 20.04, resulting in cryptic linker errors. Apparently, this issue is only happening with Go 1.19.x (I guess they've worked around that in Go 1.20, but am too lazy to take a look).Found it by experimenting with adding Ubuntu 22.04 to github.com/opencontainers/runc CI matrix. Meaning, the tests are now run on BOTH Ubuntu 20.04 and 22.04, using both Go 1.19.x and 1.20.x. IOW, here's the test matrix, simplified:
Once I managed to get it running, I started to see errors like these on Ubuntu 20.04:
By looking into setup-go logs for Ubuntu-20.04 + Go 1.19.x, I see:
Now, for Ubuntu 22.04 + Go 1.19.x I see:
💡 The issue here, as you can see, that the same cache is being used for Ubuntu 20.04 and 22.04.
Action version:
v4
Platform:
Runner type:
Tools version:
1.19.x, 1.20.x
Repro steps:
See e.g. this test run: https://github.com/opencontainers/runc/actions/runs/4654779815/jobs/8236809130 (from opencontainers/runc#3820).
Expected behavior:
No cryptic linkers errors, cache being unique per OS distro.
Actual behavior:
See above.
The text was updated successfully, but these errors were encountered: