-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract archive fix #242
Extract archive fix #242
Conversation
Hello @redanthrax. Thank you for your pull request. Could you please run the |
Hello @redanthrax. Could you please confirm that self-hosted runner works as expected with your changes ? |
Hello @dmitry-shibanov. Yes after the changes the self hosted runner works as expected. Basically Extract-Archive expects a .zip file extension so when using the filename instead of the randomly generated filename in Windows it works as expected. |
Hi @redanthrax, can you resolve conflicts with the main branch? |
@panticmilos I have resolved the conflicts. |
Hello @redanthrax. You have conflict lines in package-lock.json. Could you please fix them? |
Hi @redanthrax, Could you run |
Hi @redanthrax, since checks are still failing let's try the following steps. I believe you already have done them, but this check error is weird for me.
If there are no changes after step 4 to push let me know and thank you. |
b77aed7
to
b554e1a
Compare
@redanthrax, still has conflicts with main branch :( |
@redanthrax, just a gentle ping ☎️ |
Closed in favor of #250 |
Description:
Updated tool cache and fixed extract issue on windows.
Related issue:
Fixes #241
Check list: