Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cache in check-dist.yml #301

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Use cache in check-dist.yml #301

merged 1 commit into from
Dec 7, 2022

Conversation

jongwooo
Copy link
Contributor

@jongwooo jongwooo commented Dec 6, 2022

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Use cache in check-dist.yml
See actions/cache#1004

AS-IS

- name: Set Node.js 16.x
  uses: actions/setup-node@v3
  with:
    node-version: 16.x

TO-BE

- name: Set Node.js 16.x
  uses: actions/setup-node@v3
  with:
    node-version: 16.x
    cache: npm

It’s literally a one line change to pass the cache: npm input parameter.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@jongwooo jongwooo requested a review from a team December 6, 2022 16:01
@marko-zivic-93 marko-zivic-93 merged commit 30c39bf into actions:main Dec 7, 2022
@jongwooo jongwooo deleted the chore/use-cache-in-check-dist branch December 7, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants