Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable caching by default with default input #332

Merged
merged 8 commits into from
Mar 10, 2023
Merged

Enable caching by default with default input #332

merged 8 commits into from
Mar 10, 2023

Conversation

dsame
Copy link
Contributor

@dsame dsame commented Feb 13, 2023

Description:
Change default value for cache input

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dsame dsame force-pushed the default-cache2 branch 8 times, most recently from eae3216 to e9a61fc Compare February 14, 2023 18:44
@dsame dsame marked this pull request as ready for review February 17, 2023 07:36
@dsame dsame requested a review from a team as a code owner February 17, 2023 07:36
dmitry-shibanov
dmitry-shibanov reviewed Feb 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/cache-utils.ts Outdated Show resolved Hide resolved
IvanZosimov
IvanZosimov reviewed Feb 20, 2023
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
marko-zivic-93
marko-zivic-93 approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@marko-zivic-93 marko-zivic-93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Ivan's suggestions are fixed it will be ok with me as well.

@dsame dsame mentioned this pull request Feb 24, 2023
Closed
2 tasks
marko-zivic-93
marko-zivic-93 reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
marko-zivic-93
marko-zivic-93 reviewed Mar 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@IvanZosimov
Copy link
Contributor

IvanZosimov commented Mar 2, 2023 •
edited
Loading

As we are changing major tag to v4, do we need to update all workflow examples to use @v4 instead of @V3 ? Customers usually just copy the examples and use them in their workflows.

@dmitry-shibanov dmitry-shibanov merged commit c51a720 into actions:main Mar 10, 2023
@andyspiers
Copy link

This PR suggests using v4 but there is no tag pushed yet for v4

@dmitry-shibanov
Copy link
Contributor

Hello @andyspiers. We're planing to release a new major version during this week.

@ZekeLu ZekeLu mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panticmilos panticmilos panticmilos approved these changes

@marko-zivic-93 marko-zivic-93 marko-zivic-93 approved these changes

@IvanZosimov IvanZosimov IvanZosimov approved these changes

@MaksimZhukov MaksimZhukov MaksimZhukov approved these changes

@dmitry-shibanov dmitry-shibanov dmitry-shibanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dsame @IvanZosimov @andyspiers @dmitry-shibanov @MaksimZhukov @marko-zivic-93 @panticmilos