Add SBT in cache managers. #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laughedelic
reviewed
Mar 24, 2022
|
Hello @fmeriaux. Could you please sync with the main branch? |
Done |
|
Hello @fmeriaux. Could you please add e2e tests for sbt ? |
Yes, no problem, but can you detail a little more what I have to do? |
|
I am so sick of receiving Github emails from Subscribers 6 a day? How can I
be attached to the thread when I unsubscribed after 5 days last year?
Please delete my email
***@***.*** ***@***.***>*
Donna Murdoch
…On Tue, 12 Apr 2022, 4:50 pm Florian Meriaux, ***@***.***> wrote:
Hello @fmeriaux <https://github.com/fmeriaux>. Could you please add e2e
tests for sbt ?
Yes, no problem, but can you detail a little more what I have to do?
I think it should be something similar to Gradle
<https://github.com/actions/setup-java/blob/main/.github/workflows/e2e-cache.yml#L18-L66>
test.
Thanks, done !
—
Reply to this email directly, view it on GitHub
<#302 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVVEBHXVXZIALDGTVVEZIOTVEUMJXANCNFSM5RQPPSSQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
added 2 commits
April 12, 2022 11:53
|
According to https://github.com/coursier/cache-action#path Cache should use the default OS-dependent location. PR is updated |
dmitry-shibanov
approved these changes
Apr 20, 2022
marko-zivic-93
approved these changes
Apr 20, 2022
julienrf
reviewed
May 23, 2022
2 tasks
julienrf
added a commit
to scalacenter/website
that referenced
this pull request
Jun 28, 2022
The support of sbt caching has been implement recently in actions/setup-java#302 and actions/setup-java#332 by Florian Meriaux
dhpiggott
added a commit
to dhpiggott/helios
that referenced
this pull request
Jul 16, 2022
It has just gained support via actions/setup-java#302. See also https://github.com/actions/setup-java#caching-sbt-dependencies.
dhpiggott
added a commit
to dhpiggott/helios
that referenced
this pull request
Jul 16, 2022
It has just gained support via actions/setup-java#302. See also https://github.com/actions/setup-java#caching-sbt-dependencies. Also add type to spec in HeliosSpec.
dhpiggott
added a commit
to dhpiggott/helios
that referenced
this pull request
Jul 16, 2022
It has just gained support via actions/setup-java#302. See also https://github.com/actions/setup-java#caching-sbt-dependencies. Also add type to spec in HeliosSpec.
rtyley
added a commit
to guardian/prout
that referenced
this pull request
Dec 11, 2022
https://github.com/actions/setup-java#caching-sbt-dependencies See actions/setup-java#302 - it looks like the sbt-caching functionality was informed by https://github.com/coursier/cache-action (see actions/setup-java#302 (comment) ), so setup-java may now be the 'best' solution.
rtyley
added a commit
to guardian/prout
that referenced
this pull request
Dec 11, 2022
https://github.com/actions/setup-java#caching-sbt-dependencies See actions/setup-java#302 - it looks like the sbt-caching functionality was informed by https://github.com/coursier/cache-action (see actions/setup-java#302 (comment) ), so setup-java may now be the 'best' solution.
rtyley
added a commit
to rtyley/setup-java
that referenced
this pull request
Dec 6, 2023
…ting it's own version While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232). This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving. As such, it would be great to exclude `version.sbt` files from the cache hash key. Background: `cache: sbt` was orginally introduced with actions#302
2 tasks
rtyley
added a commit
to rtyley/setup-java
that referenced
this pull request
Dec 7, 2023
…ting it's own version While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232). This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving. As such, it would be great to exclude `version.sbt` files from the cache hash key. Background: `cache: sbt` was orginally introduced with actions#302
rtyley
added a commit
to rtyley/setup-java
that referenced
this pull request
Dec 7, 2023
…ting it's own version While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in guardian/play-secret-rotation@b215232). This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving. As such, it would be great to exclude `version.sbt` files from the cache hash key. Background: `cache: sbt` was orginally introduced with actions#302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe your changes.
Add SBT cache manager.
Related issue:
Add link to the related issue.
#266 (comment)
Check list: