feat: add support for SapMachine JDK/JRE #614

Shegox · 2024-03-27T14:09:23Z

Description:
This PR adds support for setting up the SapMachine JDK/JRE using the setup-java action.
The implementation is heavily inspired by the dragonwell implementation.
The setup-java supports setting up SapMachine for JRE and JDK for following operating systems/architectures:

macos (arm/x86)
linux (arm/x86)
linux-muse (x86) (for alpine containers)
windows (x86)

The releases URL https://sap.github.io/SapMachine/assets/data/sapmachine-releases-all.json, which is used to determine the download URL, contains the up-to-date full list of all SapMachine JDKs and JREs.

Otherwise this PR adds 21 to the list of major e2e tested versions for all releases, which works for all. If you want I can as well add it to a separate PR.

Related issue:
fixes #72
fixes SAP/SapMachine#821

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

Tested additionally via:

e2e tests: https://github.com/Shegox/setup-java/actions/runs/8452912940
SapMachine specific e2e setup tests: https://github.com/Shegox/setup-sapmachine-test/actions/workflows/matrix.yml

Co-authored-by: Christian Schwaninger <christian.schwaninger@sap.com>

RealCLanger

Great stuff. Thank you for doing this.

gdams

LGTM

gdams · 2024-04-10T15:00:11Z

@aparnajyothi-y can we get a review of this PR please

joergmann · 2024-04-16T08:08:58Z

great!

rjayasinghe · 2024-04-18T06:30:24Z

Great! Go for it! 💚

RealCLanger · 2024-05-06T14:18:52Z

@HarithaVattikuti can you take a look?

RealCLanger · 2024-05-06T14:20:08Z

@priyagupta108 can you take a look?

RealCLanger · 2024-05-07T06:32:38Z

@mahabaleshwars Could you take a look here or give us some ETA for when this can be merged? We have quite some folks waiting for this... Thanks

fniephaus · 2024-05-07T08:02:01Z

@RealCLanger #501 is stuck in a similar fashion: no response from the maintainers for months. I was told they need their lawyers to review the license of the JDK distro to ensure the distro can be integrated into this action. We went through this with them when adding Oracle JDK (#401), but somehow it now seems that process is stuck indefinitely.

RealCLanger · 2024-07-23T07:52:42Z

@stoe Could you find out something about the progress of this already?

aparnajyothi-y · 2024-07-23T11:01:47Z

Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback.

RealCLanger · 2024-07-23T13:07:37Z

Hello Everyone, We have prioritized the feature request for this Q4 to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR for the feature request. We will update you once we have some feedback.

Thanks for the update. So let's hope this can be integrated by Q4 or even sooner... 😄

skateball · 2024-08-05T13:29:18Z

Hello Everyone, We have prioritized the feature request to implement support for SapMachine JDK/JRE. We have started reviewing and testing this PR. We will update you once we have some feedback.

@aparnajyothi-y Hi, can you please give an update how long this will take?
Can we help/assist you in any way to get this PR sooner solved?
Best Regards Christian

RealCLanger · 2024-09-02T06:13:26Z

Any updates (@aparnajyothi-y) ?

aparnajyothi-y · 2024-09-02T07:32:45Z

Hello Everyone, we are in the process of reviewing this PR. We will update once the review completed.

skateball

LGTM. How long does it take that I know when to organize cake?

@johnshajiang

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.2 to 4.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>. <blockquote> <h2>v4.3.0</h2> What's Changed <ul> <li>Add support for SapMachine JDK/JRE by <a href="https://github.com/Shegox"><code>@Shegox</code></a> in <a href="https://github.com/actions/setup-java/issues/614">#614</a></li> </ul> <pre lang="yaml"><code>steps: - name: Checkout uses: actions/checkout@v4 - name: Setup-java uses: actions/setup-java@v4 with: distribution: ‘sapmachine’ java-version: ’21’ </code></pre> Bug fixes : <ul> <li> <pre><code>Fix typos on Corretto by @johnshajiang in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>IBM Semeru Enhancement on arm64 by @mahabaleshwars in [#677](actions/setup-java#677) </code></pre> </li> <li> <pre><code>Resolve Basic Validation Check Failures by @aparnajyothi-y  in [#682](actions/setup-java#682) </code></pre> </li> </ul> New Contributors : <ul> <li> <pre><code>@johnshajiang made their first contribution in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>@Shegox made their first contribution in [#614](actions/setup-java#614) </code></pre> </li> </ul> Full Changelog: <a href="https://github.com/actions/setup-java/compare/v4...v4.3.0">https://github.com/actions/setup-java/compare/v4...v4.3.0</a> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-java/commit/2dfa2011c5b2a0f1489bf9e433881c92c1631f88"><code>2dfa201</code></a> basic validation failure fix (<a href="https://github.com/actions/setup-java/issues/682">#682</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/7467385c615a13cecd14d5768e738332968d0792"><code>7467385</code></a> feat: add support for SapMachine JDK/JRE (<a href="https://github.com/actions/setup-java/issues/614">#614</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/8e04ddff28554375a9a1096c888a2ef2c9803cd7"><code>8e04ddf</code></a> Update Error Messages and Fix Architecture Detection for IBM Semeru (<a href="https://github.com/actions/setup-java/issues/677">#677</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/67fbd726daaf08212a7b021c1c4d117f94a81dd3"><code>67fbd72</code></a> Fix typos on Corretto (<a href="https://github.com/actions/setup-java/issues/665">#665</a>) (<a href="https://github.com/actions/setup-java/issues/666">#666</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-java/compare/6a0805fcefea3d4657a47ac4c165951e33482018...2dfa2011c5b2a0f1489bf9e433881c92c1631f88">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-java&package-manager=github_actions&previous-version=4.2.2&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@johnshajiang

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.2 to 4.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>. <blockquote> <h2>v4.3.0</h2> What's Changed <ul> <li>Add support for SapMachine JDK/JRE by <a href="https://github.com/Shegox"><code>@Shegox</code></a> in <a href="https://github.com/actions/setup-java/issues/614">#614</a></li> </ul> <pre lang="yaml"><code>steps: - name: Checkout uses: actions/checkout@v4 - name: Setup-java uses: actions/setup-java@v4 with: distribution: ‘sapmachine’ java-version: ’21’ </code></pre> Bug fixes : <ul> <li> <pre><code>Fix typos on Corretto by @johnshajiang in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>IBM Semeru Enhancement on arm64 by @mahabaleshwars in [#677](actions/setup-java#677) </code></pre> </li> <li> <pre><code>Resolve Basic Validation Check Failures by @aparnajyothi-y  in [#682](actions/setup-java#682) </code></pre> </li> </ul> New Contributors : <ul> <li> <pre><code>@johnshajiang made their first contribution in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>@Shegox made their first contribution in [#614](actions/setup-java#614) </code></pre> </li> </ul> Full Changelog: <a href="https://github.com/actions/setup-java/compare/v4...v4.3.0">https://github.com/actions/setup-java/compare/v4...v4.3.0</a> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-java/commit/2dfa2011c5b2a0f1489bf9e433881c92c1631f88"><code>2dfa201</code></a> basic validation failure fix (<a href="https://github.com/actions/setup-java/issues/682">#682</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/7467385c615a13cecd14d5768e738332968d0792"><code>7467385</code></a> feat: add support for SapMachine JDK/JRE (<a href="https://github.com/actions/setup-java/issues/614">#614</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/8e04ddff28554375a9a1096c888a2ef2c9803cd7"><code>8e04ddf</code></a> Update Error Messages and Fix Architecture Detection for IBM Semeru (<a href="https://github.com/actions/setup-java/issues/677">#677</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/67fbd726daaf08212a7b021c1c4d117f94a81dd3"><code>67fbd72</code></a> Fix typos on Corretto (<a href="https://github.com/actions/setup-java/issues/665">#665</a>) (<a href="https://github.com/actions/setup-java/issues/666">#666</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-java/compare/6a0805fcefea3d4657a47ac4c165951e33482018...2dfa2011c5b2a0f1489bf9e433881c92c1631f88">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-java&package-manager=github_actions&previous-version=4.2.2&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

@johnshajiang

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.2 to 4.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>. <blockquote> <h2>v4.3.0</h2> What's Changed <ul> <li>Add support for SapMachine JDK/JRE by <a href="https://github.com/Shegox"><code>@â��Shegox</code></a> in <a href="https://github.com/actions/setup-java/issues/614">#614</a></li> </ul> <pre lang="yaml"><code>steps: - name: Checkout uses: actions/checkout@v4 - name: Setup-java uses: actions/setup-java@v4 with: distribution: â��sapmachineâ�� java-version: â��21â�� </code></pre> Bug fixes : <ul> <li> <pre><code>Fix typos on Corretto by @johnshajiang in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>IBM Semeru Enhancement on arm64 byÂ @mahabaleshwars in [#677](actions/setup-java#677) </code></pre> </li> <li> <pre><code>Resolve Basic Validation Check Failures byÂ @aparnajyothi-yâ�¨Â in [#682](actions/setup-java#682) </code></pre> </li> </ul> New Contributors : <ul> <li> <pre><code>@johnshajiang made their first contribution in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>@Shegox made their first contribution in [#614](actions/setup-java#614) </code></pre> </li> </ul> Full Changelog: <a href="https://github.com/actions/setup-java/compare/v4...v4.3.0">https://github.com/actions/setup-java/compare/v4...v4.3.0</a> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-java/commit/2dfa2011c5b2a0f1489bf9e433881c92c1631f88"><code>2dfa201</code></a> basic validation failure fix (<a href="https://github.com/actions/setup-java/issues/682">#682</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/7467385c615a13cecd14d5768e738332968d0792"><code>7467385</code></a> feat: add support for SapMachine JDK/JRE (<a href="https://github.com/actions/setup-java/issues/614">#614</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/8e04ddff28554375a9a1096c888a2ef2c9803cd7"><code>8e04ddf</code></a> Update Error Messages and Fix Architecture Detection for IBM Semeru (<a href="https://github.com/actions/setup-java/issues/677">#677</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/67fbd726daaf08212a7b021c1c4d117f94a81dd3"><code>67fbd72</code></a> Fix typos on Corretto (<a href="https://github.com/actions/setup-java/issues/665">#665</a>) (<a href="https://github.com/actions/setup-java/issues/666">#666</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-java/compare/6a0805fcefea3d4657a47ac4c165951e33482018...2dfa2011c5b2a0f1489bf9e433881c92c1631f88">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-java&package-manager=github_actions&previous-version=4.2.2&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

@johnshajiang

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.2 to 4.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>. <blockquote> <h2>v4.3.0</h2> What's Changed <ul> <li>Add support for SapMachine JDK/JRE by <a href="https://github.com/Shegox"><code>@â��Shegox</code></a> in <a href="https://github.com/actions/setup-java/issues/614">#614</a></li> </ul> <pre lang="yaml"><code>steps: - name: Checkout uses: actions/checkout@v4 - name: Setup-java uses: actions/setup-java@v4 with: distribution: â��sapmachineâ�� java-version: â��21â�� </code></pre> Bug fixes : <ul> <li> <pre><code>Fix typos on Corretto by @johnshajiang in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>IBM Semeru Enhancement on arm64 byÂ @mahabaleshwars in [#677](actions/setup-java#677) </code></pre> </li> <li> <pre><code>Resolve Basic Validation Check Failures byÂ @aparnajyothi-yâ�¨Â in [#682](actions/setup-java#682) </code></pre> </li> </ul> New Contributors : <ul> <li> <pre><code>@johnshajiang made their first contribution in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>@Shegox made their first contribution in [#614](actions/setup-java#614) </code></pre> </li> </ul> Full Changelog: <a href="https://github.com/actions/setup-java/compare/v4...v4.3.0">https://github.com/actions/setup-java/compare/v4...v4.3.0</a> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-java/commit/2dfa2011c5b2a0f1489bf9e433881c92c1631f88"><code>2dfa201</code></a> basic validation failure fix (<a href="https://github.com/actions/setup-java/issues/682">#682</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/7467385c615a13cecd14d5768e738332968d0792"><code>7467385</code></a> feat: add support for SapMachine JDK/JRE (<a href="https://github.com/actions/setup-java/issues/614">#614</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/8e04ddff28554375a9a1096c888a2ef2c9803cd7"><code>8e04ddf</code></a> Update Error Messages and Fix Architecture Detection for IBM Semeru (<a href="https://github.com/actions/setup-java/issues/677">#677</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/67fbd726daaf08212a7b021c1c4d117f94a81dd3"><code>67fbd72</code></a> Fix typos on Corretto (<a href="https://github.com/actions/setup-java/issues/665">#665</a>) (<a href="https://github.com/actions/setup-java/issues/666">#666</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-java/compare/6a0805fcefea3d4657a47ac4c165951e33482018...2dfa2011c5b2a0f1489bf9e433881c92c1631f88">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-java&package-manager=github_actions&previous-version=4.2.2&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

@johnshajiang

Bumps the github-actions group with 1 update: [actions/setup-java](https://github.com/actions/setup-java). Updates `actions/setup-java` from 4.2.2 to 4.3.0 <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/actions/setup-java/releases">actions/setup-java's releases</a>. <blockquote> <h2>v4.3.0</h2> What's Changed <ul> <li>Add support for SapMachine JDK/JRE by <a href="https://github.com/Shegox"><code>@Shegox</code></a> in <a href="https://github.com/actions/setup-java/issues/614">#614</a></li> </ul> <pre lang="yaml"><code>steps: - name: Checkout uses: actions/checkout@v4 - name: Setup-java uses: actions/setup-java@v4 with: distribution: ‘sapmachine’ java-version: ’21’ </code></pre> Bug fixes : <ul> <li> <pre><code>Fix typos on Corretto by @johnshajiang in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>IBM Semeru Enhancement on arm64 by @mahabaleshwars in [#677](actions/setup-java#677) </code></pre> </li> <li> <pre><code>Resolve Basic Validation Check Failures by @aparnajyothi-y  in [#682](actions/setup-java#682) </code></pre> </li> </ul> New Contributors : <ul> <li> <pre><code>@johnshajiang made their first contribution in [#666](actions/setup-java#666) </code></pre> </li> <li> <pre><code>@Shegox made their first contribution in [#614](actions/setup-java#614) </code></pre> </li> </ul> Full Changelog: <a href="https://github.com/actions/setup-java/compare/v4...v4.3.0">https://github.com/actions/setup-java/compare/v4...v4.3.0</a> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-java/commit/2dfa2011c5b2a0f1489bf9e433881c92c1631f88"><code>2dfa201</code></a> basic validation failure fix (<a href="https://github.com/actions/setup-java/issues/682">#682</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/7467385c615a13cecd14d5768e738332968d0792"><code>7467385</code></a> feat: add support for SapMachine JDK/JRE (<a href="https://github.com/actions/setup-java/issues/614">#614</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/8e04ddff28554375a9a1096c888a2ef2c9803cd7"><code>8e04ddf</code></a> Update Error Messages and Fix Architecture Detection for IBM Semeru (<a href="https://github.com/actions/setup-java/issues/677">#677</a>)</li> <li><a href="https://github.com/actions/setup-java/commit/67fbd726daaf08212a7b021c1c4d117f94a81dd3"><code>67fbd72</code></a> Fix typos on Corretto (<a href="https://github.com/actions/setup-java/issues/665">#665</a>) (<a href="https://github.com/actions/setup-java/issues/666">#666</a>)</li> <li>See full diff in <a href="https://github.com/actions/setup-java/compare/6a0805fcefea3d4657a47ac4c165951e33482018...2dfa2011c5b2a0f1489bf9e433881c92c1631f88">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/setup-java&package-manager=github_actions&previous-version=4.2.2&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Fixes #1834 COPYBARA_INTEGRATE_REVIEW=#1834 from google:dependabot/github_actions/github-actions-bc3bba8501 ab1fc54 PiperOrigin-RevId: 672948325

Shegox requested a review from a team as a code owner March 27, 2024 14:09

feat: add support for SapMachine JDK/JRE

87eb586

Co-authored-by: Christian Schwaninger <christian.schwaninger@sap.com>

Shegox force-pushed the main branch from 13a9650 to 87eb586 Compare March 27, 2024 14:13

RealCLanger approved these changes Mar 28, 2024

View reviewed changes

gdams approved these changes Apr 10, 2024

View reviewed changes

Merge branch 'main' into main

37af9d9

fniephaus mentioned this pull request Jul 23, 2024

Add support for Oracle GraalVM #501

Open

2 tasks

priyagupta108 approved these changes Sep 2, 2024

View reviewed changes

gowridurgad approved these changes Sep 2, 2024

View reviewed changes

aparnajyothi-y approved these changes Sep 3, 2024

View reviewed changes

SkakimSAP approved these changes Sep 3, 2024

View reviewed changes

skateball approved these changes Sep 5, 2024

View reviewed changes

HarithaVattikuti approved these changes Sep 5, 2024

View reviewed changes

HarithaVattikuti merged commit 7467385 into actions:main Sep 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add support for SapMachine JDK/JRE #614

feat: add support for SapMachine JDK/JRE #614

Shegox commented Mar 27, 2024 •

edited

Loading

RealCLanger left a comment

gdams left a comment

gdams commented Apr 10, 2024

joergmann commented Apr 16, 2024

rjayasinghe commented Apr 18, 2024

RealCLanger commented May 6, 2024

RealCLanger commented May 6, 2024

RealCLanger commented May 7, 2024

fniephaus commented May 7, 2024

RealCLanger commented Jul 23, 2024

aparnajyothi-y commented Jul 23, 2024 •

edited

Loading

RealCLanger commented Jul 23, 2024

skateball commented Aug 5, 2024

RealCLanger commented Sep 2, 2024

aparnajyothi-y commented Sep 2, 2024

skateball left a comment

feat: add support for SapMachine JDK/JRE #614

feat: add support for SapMachine JDK/JRE #614

Conversation

Shegox commented Mar 27, 2024 • edited Loading

RealCLanger left a comment

Choose a reason for hiding this comment

gdams left a comment

Choose a reason for hiding this comment

gdams commented Apr 10, 2024

joergmann commented Apr 16, 2024

rjayasinghe commented Apr 18, 2024

RealCLanger commented May 6, 2024

RealCLanger commented May 6, 2024

RealCLanger commented May 7, 2024

fniephaus commented May 7, 2024

RealCLanger commented Jul 23, 2024

aparnajyothi-y commented Jul 23, 2024 • edited Loading

RealCLanger commented Jul 23, 2024

skateball commented Aug 5, 2024

RealCLanger commented Sep 2, 2024

aparnajyothi-y commented Sep 2, 2024

skateball left a comment

Choose a reason for hiding this comment

Shegox commented Mar 27, 2024 •

edited

Loading

aparnajyothi-y commented Jul 23, 2024 •

edited

Loading