Overwrite scoped registry

__tests__/authutil.test.ts

@@ -72,7 +72,13 @@ describe('authutil tests', () => {
     for (const line of contents.split(os.EOL)) {
       let parts = line.split('=');
       if (parts.length == 2) {
-        rc[parts[0].trim()] = parts[1].trim();
+        let key = parts[0].trim();
+
+        if (rc[key]) {
+          throw new Error(`Duplicate key ${key} in ${rcFile}`);
+        }
+
+        rc[key] = parts[1].trim();
       }
     }
     return rc;
@@ -132,4 +138,58 @@ describe('authutil tests', () => {
     expect(rc['always-auth']).toBe('false');
     expect(process.env.NODE_AUTH_TOKEN).toEqual('foobar');
   });
+
+  describe('Existing .npmrc', () => {
+    it('should overwrite registry', async () => {
+      fs.copyFileSync(path.join(__dirname, 'data/.npmrc'), rcFile);
+      expect(fs.statSync(rcFile)).toBeDefined();
+
+      let rc = readRcFile(rcFile);
+      expect(rc['registry']).toBe('http://example.com');
+      await auth.configAuthentication('https://registry.npmjs.org/', 'true');
+      let updatedRc = readRcFile(rcFile);
+      expect(updatedRc['registry']).toBe('https://registry.npmjs.org/');
+      expect(updatedRc['always-auth']).toBe('true');
+    });
+
+    it('should overwrite scoped registry', async () => {
+      process.env['INPUT_SCOPE'] = 'myScope';
+
+      fs.copyFileSync(path.join(__dirname, 'data/.npmrc-scoped'), rcFile);
+      expect(fs.statSync(rcFile)).toBeDefined();
+
+      let rc = readRcFile(rcFile);
+      expect(rc['@myscope:registry']).toBe('http://example.com');
+
+      await auth.configAuthentication('https://registry.npmjs.org/', 'true');
+
+      let updatedRc = readRcFile(rcFile);
+      expect(updatedRc['@myscope:registry']).toBe(
+        'https://registry.npmjs.org/'
+      );
+      expect(updatedRc['always-auth']).toBe('true');
+    });
+
+    it('should not delete registry when scoped', async () => {
+      process.env['INPUT_SCOPE'] = 'myScope';
+
+      fs.copyFileSync(
+        path.join(__dirname, 'data/.npmrc-scoped-with-registry'),
+        rcFile
+      );
+      expect(fs.statSync(rcFile)).toBeDefined();
+
+      let rc = readRcFile(rcFile);
+      expect(rc['@myscope:registry']).toBe('http://example.com');
+
+      await auth.configAuthentication('https://registry.npmjs.org/', 'true');
+
+      let updatedRc = readRcFile(rcFile);
+      expect(updatedRc['registry']).toBe('http://base.com');
+      expect(updatedRc['@myscope:registry']).toBe(
+        'https://registry.npmjs.org/'
+      );
+      expect(updatedRc['always-auth']).toBe('true');
+    });
+  });
 });

__tests__/data/.npmrc

@@ -0,0 +1 @@
+registry=http://example.com

__tests__/data/.npmrc-scoped

@@ -0,0 +1 @@
+@myscope:registry=http://example.com

__tests__/data/.npmrc-scoped-with-registry

@@ -0,0 +1,2 @@
+registry=http://base.com
+@myscope:registry=http://example.com

src/authutil.ts

@@ -32,23 +32,23 @@ function writeRegistryToFile(
     scope = scope.toLowerCase();
   }
 
+  const registryKey: string = scope ? `${scope}:registry` : 'registry';
+
   core.debug(`Setting auth in ${fileLocation}`);
   let newContents: string = '';
   if (fs.existsSync(fileLocation)) {
     const curContents: string = fs.readFileSync(fileLocation, 'utf8');
     curContents.split(os.EOL).forEach((line: string) => {
       // Add current contents unless they are setting the registry
-      if (!line.toLowerCase().startsWith('registry')) {
+      if (!line.startsWith(registryKey)) {
         newContents += line + os.EOL;
       }
     });
   }
   // Remove http: or https: from front of registry.
   const authString: string =
     registryUrl.replace(/(^\w+:|^)/, '') + ':_authToken=${NODE_AUTH_TOKEN}';
-  const registryString: string = scope
-    ? `${scope}:registry=${registryUrl}`
-    : `registry=${registryUrl}`;
+  const registryString: string = `${registryKey}=${registryUrl}`;
   const alwaysAuthString: string = `always-auth=${alwaysAuth}`;
   newContents += `${authString}${os.EOL}${registryString}${os.EOL}${alwaysAuthString}`;
   fs.writeFileSync(fileLocation, newContents);