-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The entire package.json is used as the "node version" when using node-versions-file
#864
Comments
PR to fix here: #865 |
Hello @NullVoxPopuli, |
I think the above poster ikjot161290 is a bot, not sure how to report comments on github.. |
Hello @NullVoxPopuli, Released the PR yesterday. For now I am going to close the issue. If you have any concerns feel free to ping us. |
Thatk you! Already using the new version in: https://github.com/marketplace/actions/all-in-one-setup-node-pnpm-cache |
Description:
There is a message about not finding the node version in the manifest, so it says it'll fallback to downloading node, but it uses the entire package.json as the "node version", rather than an actual semver-style version
Example: https://github.com/NullVoxPopuli/actions-testing/actions/runs/6410471015/job/17403838984
Action version:
v3
Platform:
Runner type:
Tools version:
defaults
Repro steps:
a job that does:
https://github.com/NullVoxPopuli/actions-testing/blob/main/.github/workflows/testing.yml#L29-L39
Another example, where I put a
name
entry in the package.jsonResults in:
https://github.com/NullVoxPopuli/actions-testing/actions/runs/6410629979/job/17404330263#step:4:11
Expected behavior:
ignore node-version-file, since it does not contain a node version, and the entire file itself (which is json) is not a valid version)
Actual behavior:
the entire json file is being used as the version.
The text was updated successfully, but these errors were encountered: