-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow post-action after v4 #878
Comments
I noticed that my workflow files didn't specify what node version to use for this workflow through any |
Thank you for detailed description of the issue! We'll investigate it and come back with details. |
My workflows do always specify I also have a flow log here which despite requesting lts/iron resolved |
Just want to report the same thing, from 5s -> 2m15s (Node 18) |
Same here in multiple projects using JS with Yarn. The It seems to me that this only happens when JS dependencies have been updated. Re-running the job (which causes a cache hit) is fast again - perhaps because the cache doesn't need to be saved. My conclusion: Saving the cache is significantly slower with v4 than with v3. |
Noticing this as well because I have an aggressive I concur with @ledermann that the issue is somewhere in cache-saving. With a cache hit, the post-action takes Without a cache hit, when trying to save the cache, the post-action times out: |
See ruby/setup-ruby#543 which explains a possible cause and fix. |
And here's the fix: ruby/setup-ruby@036ef45 that should probably be ported to setup-node |
* revert setup-node action to v3 because of slow post action step see issue: actions/setup-node#878 * fix build commands
@nikolai-laevskii I opened a PR in #907 that applies the same fix as https://github.com/ruby/setup-ruby (issue ruby/setup-ruby#543, PR ruby/setup-ruby#546), could you take a look at it? |
I'm also experiencing this on Node 18. |
@nrutman Actually this issue does not depend on the Node version you're using, but rather the Node version that the GitHub Action runner uses itself (in this case, the runner for |
Hello everyone. We've merged the fix for the issue. Could you please try to use |
Hi! Yeah, from some quick tests it seems to work better now. |
@dmitry-shibanov Just confirming that the fix has worked for us too We only really noticed it on Windows where all those tiny Before![]() After![]() |
@dmitry-shibanov Can you release the changes? |
Hello everyone. We released the changes yesterday. For now I am going to close the issue. If you have any concerns feel free to ping us. |
Issue was related to cmd failing, and for some reason NODE action hanged...once I fixed other issue, it works again. SRY to bother |
Description:
The post-action step for this action seems to have become much slower after version 4.0.0 was released.
In the two included images, the only major difference should be the version of
actions/setup-node
.Before:
![image](https://private-user-images.githubusercontent.com/38653456/277565445-bafe9670-a139-4c2d-aa66-d9344fcdfc84.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0MDg4MTQsIm5iZiI6MTcyNDQwODUxNCwicGF0aCI6Ii8zODY1MzQ1Ni8yNzc1NjU0NDUtYmFmZTk2NzAtYTEzOS00YzJkLWFhNjYtZDkzNDRmY2RmYzg0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDEwMjE1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlMDFhYWEwZjY4MjAzODc5OWNlZmM4NzRmMDBjMzA0ZTY2N2VlZDFjZWE5YjE3NTE3OGVhYmE0NGUzNWEwM2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.X6nPYLrVmmP-7n5_itJvB_mvRvJOiigboIXWT3EvTWg)
After:
![image](https://private-user-images.githubusercontent.com/38653456/277565480-525afa09-fcd5-47ac-b131-ff6cf1f556bd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ0MDg4MTQsIm5iZiI6MTcyNDQwODUxNCwicGF0aCI6Ii8zODY1MzQ1Ni8yNzc1NjU0ODAtNTI1YWZhMDktZmNkNS00N2FjLWIxMzEtZmY2Y2YxZjU1NmJkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIzVDEwMjE1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ1MzJkZmU4MGVkNjY1YzkyNGEyMTAzZWE0N2JiNzQ1NjMyM2I5OTJiMTJjNjEwZGJhOWFiNTEwOWZmYTk5NmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.op9e1HyelOa6p0ooGT5R1rfsk7zI-jNN8_hZda-7ViM)
Action version:
Using
actions/setup-node@v4
15 hours after 4.0.0 was released.Platform:
Runner type:
Tools version:
Node 18.18.2, and
Yarn@4.0.0
.The text was updated successfully, but these errors were encountered: