-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download from node-versions and fallback to node dist #147
Changes from 30 commits
ecf0ce6
8885b71
889def3
ec6092f
1c2f59f
22c0aea
8a1d983
efab84a
ed3a918
2bdb2ab
501fd29
e3ad114
2fb08c4
5e5ef8f
1b2d431
c8617ac
42746a4
a414557
f7c5caf
dd6f5ab
11f9205
beb2155
9fcef3f
6a1b66a
8e22109
5e7b076
a80a170
a875da2
0a9e8b1
2a0fbec
2ae9264
e73ffbc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
name: build-test | ||
|
||
on: | ||
pull_request: | ||
paths-ignore: | ||
- '**.md' | ||
push: | ||
branches: | ||
- master | ||
- releases/* | ||
paths-ignore: | ||
- '**.md' | ||
|
||
jobs: | ||
build: | ||
runs-on: ${{ matrix.operating-system }} | ||
strategy: | ||
matrix: | ||
operating-system: [ubuntu-latest, windows-latest] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Setup node 12 | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: 12.x | ||
- run: npm ci | ||
- run: npm run build | ||
- run: npm run format-check | ||
- run: npm test | ||
- name: Verify no unstaged changes | ||
if: runner.os != 'windows' | ||
run: __tests__/verify-no-unstaged-changes.sh |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
name: proxy | ||
|
||
on: | ||
pull_request: | ||
paths-ignore: | ||
- '**.md' | ||
push: | ||
branches: | ||
- master | ||
- releases/* | ||
paths-ignore: | ||
- '**.md' | ||
|
||
jobs: | ||
test-proxy: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
container: | ||
image: ubuntu:latest | ||
options: --dns 127.0.0.1 | ||
services: | ||
squid-proxy: | ||
image: datadog/squid:latest | ||
ports: | ||
- 3128:3128 | ||
env: | ||
https_proxy: http://squid-proxy:3128 | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Clear tool cache | ||
run: rm -rf $RUNNER_TOOL_CACHE/* | ||
- name: Setup node 10 | ||
uses: ./ | ||
with: | ||
node-version: 10.x | ||
- name: Verify node and npm | ||
run: __tests__/verify-node.sh 10 | ||
|
||
test-bypass-proxy: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
env: | ||
https_proxy: http://no-such-proxy:3128 | ||
no_proxy: api.github.com,github.com,nodejs.org,registry.npmjs.org,*.s3.amazonaws.com,s3.amazonaws.com | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Clear tool cache | ||
run: rm -rf $RUNNER_TOOL_CACHE/* | ||
- name: Setup node 11 | ||
uses: ./ | ||
with: | ||
node-version: 11 | ||
- name: Verify node and npm | ||
run: __tests__/verify-node.sh 11 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
name: versions | ||
|
||
on: | ||
pull_request: | ||
paths-ignore: | ||
- '**.md' | ||
push: | ||
branches: | ||
- master | ||
- releases/* | ||
paths-ignore: | ||
- '**.md' | ||
|
||
jobs: | ||
versions: | ||
runs-on: ${{ matrix.operating-system }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
operating-system: [ubuntu-latest, windows-latest] | ||
defaults: | ||
run: | ||
shell: bash | ||
steps: | ||
- uses: actions/checkout@v2 | ||
# test version that falls through to node dist | ||
- name: Setup node 11 from dist | ||
uses: ./ | ||
with: | ||
node-version: 11 | ||
- name: Verify node and npm | ||
run: __tests__/verify-node.sh 11 | ||
# test old versions which didn't have npm and layout different | ||
- name: Setup node 0.12.18 from dist | ||
uses: ./ | ||
with: | ||
node-version: 0.12.18 | ||
- name: Verify node | ||
shell: bash | ||
run: __tests__/verify-node.sh 0.12.18 SKIP_NPM | ||
# test version from node manifest | ||
- name: Setup node 12.16.2 from manifest | ||
uses: ./ | ||
with: | ||
node-version: 12.16.2 | ||
- name: Verify node and npm | ||
run: __tests__/verify-node.sh 12 |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,9 @@ node_modules/ | |
lib/ | ||
__tests__/runner/* | ||
|
||
validate/temp | ||
validate/node | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I created a bash script to automate interactively validating without queuing a full run |
||
|
||
# Rest of the file pulled from https://github.com/github/gitignore/blob/master/Node.gitignore | ||
# Logs | ||
logs | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
{ | ||
// Use IntelliSense to learn about possible attributes. | ||
// Hover to view descriptions of existing attributes. | ||
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
"version": "0.2.0", | ||
"configurations": [ | ||
{ | ||
"name": "Debug Jest Tests on Nix", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was able to step through jest tests with this. It works on mac / linux and I saw mention of different configs for windows but I didn't do that yet or validate so I called Nix. |
||
"type": "node", | ||
"request": "launch", | ||
"runtimeArgs": [ | ||
"--inspect-brk", | ||
"${workspaceRoot}/node_modules/.bin/jest", | ||
"--runInBand" | ||
], | ||
"console": "integratedTerminal", | ||
"internalConsoleOptions": "neverOpen", | ||
"port": 9229 | ||
} | ||
] | ||
} |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I separated these into separate workflows so I can show badges for build-test, versions and proxy status on the readme. In general I like the separation.