-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghes support #157
ghes support #157
Conversation
ericsciple
commented
May 15, 2020
•
edited
Loading
edited
- Remote auth token when calling Dotcom from GHES
- Make download from Releases best effort
@@ -4618,6 +4618,7 @@ const core = __importStar(__webpack_require__(470)); | |||
const installer = __importStar(__webpack_require__(749)); | |||
const auth = __importStar(__webpack_require__(202)); | |||
const path = __importStar(__webpack_require__(622)); | |||
const url_1 = __webpack_require__(835); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore index.js, review .ts
let info: INodeVersionInfo | null = null; | ||
|
||
// | ||
// Try download from internal distribution (popular versions only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get info + download inside try/catch
The formatting rules bloat the line count. We might be on old formatting rules.
f08ba32
to
d59bcf2
Compare
} | ||
|
||
// | ||
// Extract | ||
// | ||
console.log('Extracting ...'); | ||
let extPath: string; | ||
info = info || ({} as INodeVersionInfo); // satisfy compiler, never null when reaches here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool
Wait for actions/toolkit#460 to merge then bump tool-cache |
222d743
to
0c1123b
Compare
0c1123b
to
e37249e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gh pr checkout 157