Fix to run tests on non-x64 architecture #502
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The test fails when run on non-x86 architectures such as Apple Silicon.
The return value of
os.arch()
can be replaced using Jest'sspyOn()
so that tests can be run on non-x86 architectures, but this does not work as expected in certain cases.setup-node/__tests__/installer.test.ts
Lines 54 to 55 in ed1a46e
In this case,
os.arch()
is called with the default parameter, so it cannot be replaced.https://github.com/actions/toolkit/blob/8263c4d15d3a8616851e9c7762ce46fbb4f8c552/packages/tool-cache/src/tool-cache.ts#L638
Therefore, I have changed it to pass values instead of relying on default values.
Related issue:
N/A
Check list: