-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect cached folders from multiple directories #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsame
force-pushed
the
project-dir
branch
6 times, most recently
from
April 19, 2023 14:21
3e5c14d
to
15c2532
Compare
This comment was marked as outdated.
This comment was marked as outdated.
dsame
force-pushed
the
project-dir
branch
5 times, most recently
from
April 24, 2023 09:54
bca9c4f
to
3527195
Compare
dsame
force-pushed
the
project-dir
branch
2 times, most recently
from
May 8, 2023 16:50
c0ab8e3
to
b67cbdb
Compare
dsame
force-pushed
the
project-dir
branch
4 times, most recently
from
May 17, 2023 07:58
a690446
to
4ce3252
Compare
dsame
changed the title
Detect current working directory
Detect cached folders from multiple directories
May 17, 2023
dsame
force-pushed
the
project-dir
branch
3 times, most recently
from
May 19, 2023 18:33
b2328f1
to
47381ae
Compare
2 tasks
dsame
force-pushed
the
project-dir
branch
4 times, most recently
from
June 6, 2023 13:53
001e87e
to
49b76fb
Compare
dsame
force-pushed
the
project-dir
branch
6 times, most recently
from
June 8, 2023 12:18
2308e96
to
e6a6894
Compare
dsame
force-pushed
the
project-dir
branch
3 times, most recently
from
June 16, 2023 12:45
8951c11
to
f792668
Compare
IvanZosimov
approved these changes
Jun 20, 2023
MaksimZhukov
approved these changes
Jun 20, 2023
marko-zivic-93
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Traverse all the sub directories derived from cache-dependency-path input and add detect all dependencies directories to cache.
The key change is to replace
getCacheDirectoryPath
withgetCacheDirectoriesPaths
The major changes are:
PackageManagerInfo
to havename
field (to avoid passing it as a parameter tomany functions) and replace string property
getCacheFolderCommand
with a functiongetCacheFolderPath: (projectDir?: string) => Promise<string>
expandCacheDependencyPath
to expand stringcache-dependency-path
input that can be eitherone file or glob pattern and multiline list of files or glob patterns
The other code changes are clue and mappings from expanded
cache-dependency-path
to the array of directories to cache.and minor but worth to be noted change is
src/cache-save.ts
Related issue:
link to original issue
link to milestone issue
Check list: