-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding support for linux ppc64le #862
base: main
Are you sure you want to change the base?
Conversation
testing performed
root@adilhusain-centos-test-1:
|
Hello @adilhusain-s. Thank you for your pull request. Could you please take a look at this comment about our concerns for these changes? |
@dmitry-shibanov
if someone can give me the value of os.arch and os.endianess on iax-ppc64, I'll be more than happy to update my PR with the changes to support iax-ppc64. |
I've updated this PR to address the requested changes.
please look at the following output: bash-5.1# cat os.js
const os = require('os');
// Get the operating system name
const osName = os.type();
console.log(`Operating System: ${osName}`);
console.log ("os platform: ", os.platform());
// Get the processor architecture
const processorArchitecture = os.arch();
console.log(`Architecture: ${processorArchitecture}`);
// Get the endianness (byte order)
const endianness = os.endianness();
console.log(`Endianness: ${endianness}`);
bash-5.1# ./node os.js
Operating System: AIX
os platform: aix
Architecture: ppc64
Endianness: BE
root@adilhusain-centos-test-1:~# node os.js
Operating System: Linux
os platform: linux
Architecture: ppc64
Endianness: LE |
Hello @adilhusain-s. Sorry for misinformation. Initially setup-node does not support aix so your previous changes should be good. Could you please revert changes to the previous ones? |
@dmitry-shibanov |
Quick update: There seems to be problem with failing tests. It should be resolved as soon as https://github.com/actions/setup-node/pull/882 is merged. For now everything looks good. |
Looks like #882 is merged. Hoping that this PR can also be merged soon. |
Hi just rebased my PR. |
Description:
*Adding change to support ppc64le architecture
Please review and merge.
Related issue:
Add link to the related issue.
Check list: