-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPy's resolvedPyPyVersion
has a trailing newline
#609
Comments
I'm working to resolve this now and will open a PR shortly. |
Hello @kurtmckee! Thank you for reporting this! |
Thanks @e-korolevskii! I think I've fixed this in PR #610. Please take a look when you have an opportunity. 😀 |
Hello @kurtmckee. We've merged your pull request. Could you please try to use setup-python as |
Will do! I'll report back shortly. |
Hello @kurtmckee. Thank you for your response. For now I'll reopen the until the new version is released. |
The fix was released in v4.6.0. Closing. |
Description:
While working on #606 I discovered that PyPy's
resolvedPyPyVersion
contains a trailing newline, which causes thepythonVersion
(passed tocacheDependencies
) to look like7.3.11\n-3.9.16
.Action version:
I'm running code against the
main
branch. The bug only exists on Ubuntu and macOS runners. The Windows runner does not have the trailing newline.Platform:
Runner type:
Tools version:
PyPy 7.3.11 with Python 3.9.16
Repro steps:
You can see the issue in the output of the "Installed versions" output group. I've created a repo to demonstrate the issue with a simple workflow:
https://github.com/kurtmckee/demonstrate-pypy-newlines/actions/runs/4151696169/jobs/7182162044
Expected behavior:
I expect that the
resolvedPyPyVersion
variable will not have a trailing newline.Actual behavior:
resolvedPyPyVersion
has a trailing newline, and this can be seen in the "Installed versions" output group's text:On Ubuntu and macOS:
On Windows:
The text was updated successfully, but these errors were encountered: