Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to parse pyproject.toml file when run on Windows #935

Closed
2 of 5 tasks
nfelt14 opened this issue Aug 30, 2024 · 7 comments
Closed
2 of 5 tasks

Failure to parse pyproject.toml file when run on Windows #935

nfelt14 opened this issue Aug 30, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@nfelt14
Copy link

nfelt14 commented Aug 30, 2024

Description:

The action is failing with this error message when run on a Windows runner.

Error: Control characters (codes < 0x1f and 0x7f) are not allowed in comments, use \u000d instead at row 19, col 61, pos 454:
18: omit = [
19>   "**/tm_devices/commands/**"  # TODO: remove this exclusion
                                                                ^
20: ]

Action version:
I believe that it is v5.2.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Repro steps:

Workflow run: https://github.com/tektronix/tm_devices/actions/runs/10624903656/job/29454004640?pr=293

Here is a snippet of the toml file that is failing to be read:

[tool.coverage.report]
exclude_lines = [
  "if TYPE_CHECKING:",
  "pragma: no cover",
  "raise NotImplementedError"
]
fail_under = 100
omit = [
  "**/tm_devices/commands/**"  # TODO: remove this exclusion
]
show_missing = true
skip_empty = true

[tool.poetry.dependencies]
python = "^3.8"  # This is the main Python version requirement

Expected behavior:

I expect it to parse the toml file the same way that it works on Ubuntu and MacOS.

Actual behavior:

The file is unable to be parsed due to a false failure for a character that doesn't seem to actually be there.

@mahabaleshwars
Copy link

Hello @nfelt14,
Thank you for creating this issue. We will investigate it and provide feedback as soon as we have some updates.

@FirelightFlagboy
Copy link

This issue is fixed by #938 or additional change is required ?

@priya-kinthali
Copy link
Contributor

Hello👋,
Thank you for bringing this issue to our attention. We have merged PR with the necessary changes into the main branch.
Could you please try using setup-python@main and let us know if the issue is resolved? We appreciate your patience and understanding.

FirelightFlagboy added a commit to Scille/parsec-cloud that referenced this issue Sep 9, 2024
The the commit actions/setup-python@29a37be
over 5.2.0 because it include a fix the windows system that doesn't handle CRLF well.

The reason for this is `actions/setup-python` is looking for project to test that change:
actions/setup-python#935 (comment)
github-merge-queue bot pushed a commit to Scille/parsec-cloud that referenced this issue Sep 9, 2024
The the commit actions/setup-python@29a37be
over 5.2.0 because it include a fix the windows system that doesn't handle CRLF well.

The reason for this is `actions/setup-python` is looking for project to test that change:
actions/setup-python#935 (comment)
@FirelightFlagboy
Copy link

Hello @priya-kinthali

I've updated our workflows to use the commit 29a37be in Scille/parsec-cloud@644618d

At least where the update to 5.2.0 was failing in the PR Scille/parsec-cloud#8285 the problems where resolve once using the latest commit in main

@priya-kinthali
Copy link
Contributor

Hello @nfelt14 👋,
Just a gentle reminder to check if the issue has been resolved with the setup-python@main.
Could you please confirm? Thanks!

@nfelt14
Copy link
Author

nfelt14 commented Sep 18, 2024

Hello @nfelt14 👋, Just a gentle reminder to check if the issue has been resolved with the setup-python@main. Could you please confirm? Thanks!

Yes, I just confirmed that this works on the main branch.

@priya-kinthali
Copy link
Contributor

Thankyou for the update!

glenn20 added a commit to glenn20/glenn20-ci-test that referenced this issue Oct 2, 2024
On Windows, the action fails with invalid ctrl chars in comments.
See actions/setup-python#935.

Remember to revert to v5 when v5.3 is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants