-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Python version in pip cache key #303
Conversation
6b3d987
to
45cf4cf
Compare
Hello @hugovk. Thank you for your pull request. Could you please sync with the main branch and run the |
45cf4cf
to
95b9974
Compare
Done! After |
eba23d0
to
7ccd7e6
Compare
Not sure why these are failing, they pass on my fork: https://github.com/hugovk/setup-python/actions/runs/1643387334 |
Hello @hugovk. Sorry for the late response. Could please sync with the main branch. Builds should be fixed. |
7ccd7e6
to
fcd6854
Compare
Rebased and CI passes, thanks! ✅ |
Hello @hugovk! Thank you for the contribution! |
Description:
Like we do for pipenv, let's include the Python version in the pip cache key.
Without it, PyPy jobs continually build wheels from source, which is slow, and they never make it into the pip cache because there are prebuilt wheels for CPython jobs already in the cache.
Related issue:
Fixes #288.
Fixes #304.
Check list: