Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't override AGENT_TOOLSDIRECTORY if it's not needed #564

Closed

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Dec 11, 2022

Description:
Don't override AGENT_TOOLSDIRECTORY if it's not needed:

AGENT_TOOLSDIRECTORY is always overriden on macOS.
This seems to be needed because CPython < 3.11 x64 builds are not relocatable
It means this is not needed for PyPy and also not needed when targetting macOS arm64 runners.

Related issue:
Towards #547

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

`AGENT_TOOLSDIRECTORY` is always overriden on macOS.
This seems to be needed because CPython < 3.11 x64 builds are not relocatable.
It means this is not needed for PyPy and also not needed when targetting macOS arm64 runners.
@mayeut mayeut requested a review from a team December 11, 2022 17:08
@brcrista
Copy link
Contributor

@dsame could you have a look at this? It's related to #394

I believe this section of the docs explains why we do this.

@mayeut I understand why we don't need it for PyPy, but could you explain why it's not needed for macOS arm64 runners?

@dsame dsame self-assigned this Dec 15, 2022
@mayeut
Copy link
Contributor Author

mayeut commented Dec 26, 2022

This would need a full rework with the new multi versions support.
Closing for now.

but could you explain why it's not needed for macOS arm64 runners?

@brcrista, if using universal2 installers as proposed in actions/python-versions#214, then the python installation is always installed in a fixed framework location and the tool cache only manages symlinks. We can create those symlinks wherever we want.

@mayeut mayeut closed this Dec 26, 2022
@mayeut mayeut deleted the macos-no-override-agent-tools-directory branch December 26, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants