Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stale label when issue is tagged with exempt label after marking stale #136

Closed
embano1 opened this issue Aug 5, 2020 · 11 comments · Fixed by #268 or C0ZEN/stale#5
Closed
Labels
enhancement New feature or request keep

Comments

@embano1
Copy link

embano1 commented Aug 5, 2020

If an exempt label, e.g. wip is added after the action ran and marked an issue as stale it would be nice to remove the stale label by the action in the next run. Right now the code seems to only consider exempt labels for skipping but not removing previously labeled issues.

@hross
Copy link
Contributor

hross commented Aug 28, 2020

I like this idea and may look at making a change. May take me some time so if you want to add the enhancement, feel free to submit a PR and I can review/merge.

@C0ZEN
Copy link
Contributor

C0ZEN commented Sep 9, 2020

Good idea.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@C0ZEN
Copy link
Contributor

C0ZEN commented Oct 15, 2020

Reopen please? @hross

@hross
Copy link
Contributor

hross commented Oct 15, 2020

Will reopen and see if we get a PR/feedback.

@hross hross reopened this Oct 15, 2020
@github-actions github-actions bot removed the Stale label Oct 16, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Nov 16, 2020
@C0ZEN
Copy link
Contributor

C0ZEN commented Nov 16, 2020

Up to avoid stale.

@github-actions github-actions bot removed the Stale label Nov 17, 2020
@hross hross removed their assignment Nov 20, 2020
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Dec 21, 2020
@C0ZEN
Copy link
Contributor

C0ZEN commented Dec 21, 2020

Up to avoid stale.

@github-actions github-actions bot removed the Stale label Dec 22, 2020
@chadwhitacre
Copy link
Contributor

Pretty thrashy. "Up to avoid stale" is the new "+1"? :^P

@hross hross added the keep label Jan 15, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jan 16, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jan 16, 2021
hross pushed a commit that referenced this issue Jan 17, 2021
* refactor(issue): create a dedicated function to remove the stale label

* refactor: prefix private methods with _

to make it consistent with others methods

* feat(label): remove the stale label when labeled with an exempt one

closes #136

* chore: fix logger issues due to rebase

@hross I think there is a room for improvement regarding the class creation of the issue logger (code duplication) but I do not see how to do it without changing a lot of stuff; do you have an idea?

* test: use strict equal and move the new test in a more logical position

* docs(readme): fix parsing error of the default values in the table

prettier was not liking the previous syntax
@Skeen
Copy link

Skeen commented Jul 30, 2021

Pretty thrashy. "Up to avoid stale" is the new "+1"? :^P

+1 ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request keep
Projects
None yet
5 participants