-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stale-issue/pr-message
is required even if skip-stale-issue/pr-message
is set to true
#405
Comments
stale-issue/pr-message
required even if skip-stale-issue/pr-message
is setstale-issue/pr-message
is required even if skip-stale-issue/pr-message
is set
stale-issue/pr-message
is required even if skip-stale-issue/pr-message
is setstale-issue/pr-message
is required even if skip-stale-issue/pr-message
is set to true
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
up |
Related to #455 |
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
May 23, 2021
Closes actions#405 Closes actions#455 BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
3 tasks
C0ZEN
added a commit
to C0ZEN/stale
that referenced
this issue
May 25, 2021
Closes actions#405 Closes actions#455 BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message
luketomlinson
pushed a commit
that referenced
this issue
May 25, 2021
…#457) * feat(options): simplify config by removing skip stale message options Closes #405 Closes #455 BREAKING CHANGES: remove skip-stale-issue-message and skip-stale-pr-message options. If you used this option, replace it by an empty message for the options stale-issue-message and stale-pr-message * build(dist): update dist also lint some files * docs(readme): update the docs by removing the skip options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
stale-issue-message
/stale-pr-message
should probably not be required ifskip-stale-issue-message
/skip-stale-pr-message
is set totrue
, since that string never gets used.Workaround: set
skip-stale-issue-message
/skip-stale-pr-message
to a non-empty string.I think this happens because the check for a commit message (
stale/src/classes/issues-processor.ts
Lines 151 to 156 in b717aa9
stale/src/classes/issues-processor.ts
Lines 265 to 269 in b717aa9
Example workflow: https://github.com/neverendingqs/serverless-dotenv-plugin/blob/8c02adbc653a90d681d5ededbb40300677cb8eac/.github/workflows/issues-cron.yml
Example run: https://github.com/neverendingqs/serverless-dotenv-plugin/runs/2209947040?check_suite_focus=true#step:2:35
The text was updated successfully, but these errors were encountered: