feat(remove-stale-when-updated): Split remove-stale-when-updated option into remove-stale-when-updated and remove-stale-when-commented #390
Conversation
|
@francoiscampbell I saw this not long ago in the code #373 (comment) |
|
Oh sure. I had originally assumed (we just started using this action yesterday) that the label was an indication of whether the PR was "eligible" for closing or not, and felt that if updating the PR delays the closing, it's not stale anymore and therefore the label should be removed. It's unfortunate that the current name of the option is |
|
I like the name of the options you propose. It makes sense and you can transform a bug into a fix with a new feature giving more control so I like that. |
francoiscampbell
force-pushed
the
remove-label-on-update
branch
from
68cb3af
to
b717aa9
Compare
francoiscampbell
changed the title
|
@C0ZEN Sounds good, I've gone and done the option split. Also updated the the PR title and description. |
|
Can you add the option in the readme? |
…on into remote-stale-when-updated and remote-stale-when-commented
francoiscampbell
force-pushed
the
remove-label-on-update
branch
from
51a7525
to
dccf347
Compare
|
Ah oops, done. |
|
@C0ZEN Do you think this is ready to merge? |
francoiscampbell
changed the title
|
@francoiscampbell conflicts FYI |
| @@ -32,7 +32,8 @@ Every argument is optional. | |||
| | `only-pr-labels` | Only PRs with ALL these labels are checked.<br>Separate multiple labels with commas (eg. "question,answered").<br>_Override `only-labels`_. | | |||
| | `any-of-labels` | Only issues and PRs with ANY of these labels are checked.<br>Separate multiple labels with commas (eg. "incomplete,waiting-feedback"). | | |||
| | `operations-per-run` | Maximum number of operations per run.<br>GitHub API CRUD related.<br>_Defaults to **30**_. | | |||
| | `remove-stale-when-updated` | Remove stale label from issue/PR on updates or comments.<br>_Defaults to **true**_. | | |||
| | `remove-stale-when-commented` | Remove stale label from issue/PR on comments.<br>_Defaults to **true**_. | | |||
| | `remove-stale-when-updated` | Remove stale label from issue/PR on any update, including comments.<br>_Defaults to **true**_. | | |||
There was a problem hiding this comment.
Doesn't this make more sense? I can't tell if this is doc typo or intentional as I am not familiar with the code base.
| | `remove-stale-when-updated` | Remove stale label from issue/PR on any update, including comments.<br>_Defaults to **true**_. | | |
| | `remove-stale-when-updated` | Remove stale label from issue/PR on any update, excluding comments.<br>_Defaults to **true**_. | |
|
Can i fix these conflicts and open PR? |
|
Since everyone is waiting for this I will do it. |
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
* feat(options): add new options to avoid stale based on comments Helping to close #441, #470, #435? Closes #390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false * style(readme): fix table syntax due to rebase * docs(readme): add permissions only for the new options
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
Helping to close actions#441, actions#470, actions#435? Closes actions#390 due to no activity BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
Currently, although updated PRs are not closed when updated, the stale label is not removed, even after re-running the action:
(redacted because this is not my PR)
This PR also removes the label when the PR is updated (for example by pushing a new commit).This PR splits the options to remove the stale by renaming
remove-stale-when-updatedtoremove-stale-when-commentedand introducing a new meaning toremove-stale-when-updated, which is to remove the stale label when the stale issue is updated in other ways than comments (typically pushing a new commit).This also happens to fix (what I think is) a bug that was reported to me today: if an issue has a stale label and then updated without comments, the stale timer isn't reset and the issue is still closed after
days-before-close, notdays-before-stale + days-before-closeas expected.